diff options
| author | Philipp Stanner <pstanner@redhat.com> | 2023-11-02 20:26:13 +0100 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2023-11-08 10:26:27 +0100 |
| commit | cc9c54232f04aef3a5d7f64a0ece7df00f1aaa3d (patch) | |
| tree | ed5160827e15e024e4eaa8c527c325992f56cbc9 | |
| parent | e8183fa10c25c7b3c20670bf2b430ddcc1ee03c0 (diff) | |
| download | linux-cc9c54232f04aef3a5d7f64a0ece7df00f1aaa3d.tar.gz | |
i2c: dev: copy userspace array safely
i2c-dev.c utilizes memdup_user() to copy a userspace array. This is done
without an overflow check.
Use the new wrapper memdup_array_user() to copy the array more safely.
Suggested-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
| -rw-r--r-- | drivers/i2c/i2c-dev.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index a91201509bc169..8b7e599f167411 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -450,8 +450,8 @@ static long i2cdev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) if (rdwr_arg.nmsgs > I2C_RDWR_IOCTL_MAX_MSGS) return -EINVAL; - rdwr_pa = memdup_user(rdwr_arg.msgs, - rdwr_arg.nmsgs * sizeof(struct i2c_msg)); + rdwr_pa = memdup_array_user(rdwr_arg.msgs, + rdwr_arg.nmsgs, sizeof(struct i2c_msg)); if (IS_ERR(rdwr_pa)) return PTR_ERR(rdwr_pa); |