diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2023-11-14 10:48:07 +0100 |
|---|---|---|
| committer | Carlos Maiolino <cem@kernel.org> | 2023-11-14 13:32:51 +0100 |
| commit | e01fe994efb34371b42ffaba95cef2b11213742c (patch) | |
| tree | 81ae6d7ad86dc29e1bc4275954201d3a2e6aa06b | |
| parent | f99988c2fbfea7b19b8ef174ba0175a540861f10 (diff) | |
| download | xfsprogs-dev-e01fe994efb34371b42ffaba95cef2b11213742c.tar.gz | |
xfs: fix log recovery when unknown rocompat bits are set
Source kernel commit: 74ad4693b6473950e971b3dc525b5ee7570e05d0
Log recovery has always run on read only mounts, even where the primary
superblock advertises unknown rocompat bits. Due to a misunderstanding
between Eric and Darrick back in 2018, we accidentally changed the
superblock write verifier to shutdown the fs over that exact scenario.
As a result, the log cleaning that occurs at the end of the mounting
process fails if there are unknown rocompat bits set.
As we now allow writing of the superblock if there are unknown rocompat
bits set on a RO mount, we no longer want to turn off RO state to allow
log recovery to succeed on a RO mount. Hence we also remove all the
(now unnecessary) RO state toggling from the log recovery path.
Fixes: 9e037cb7972f ("xfs: check for unknown v5 feature bits in superblock write verifier"
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
| -rw-r--r-- | libxfs/xfs_sb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libxfs/xfs_sb.c b/libxfs/xfs_sb.c index 1e71d43d0a..01935017cb 100644 --- a/libxfs/xfs_sb.c +++ b/libxfs/xfs_sb.c @@ -264,7 +264,8 @@ xfs_validate_sb_write( return -EFSCORRUPTED; } - if (xfs_sb_has_ro_compat_feature(sbp, XFS_SB_FEAT_RO_COMPAT_UNKNOWN)) { + if (!xfs_is_readonly(mp) && + xfs_sb_has_ro_compat_feature(sbp, XFS_SB_FEAT_RO_COMPAT_UNKNOWN)) { xfs_alert(mp, "Corruption detected in superblock read-only compatible features (0x%x)!", (sbp->sb_features_ro_compat & |