diff options
| author | Jianglei Nie <niejianglei2021@163.com> | 2022-09-14 09:42:38 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-09-21 12:50:57 +0100 |
| commit | 65e5d27df61283e5390f04b09dc79cd832f95607 (patch) | |
| tree | dd9a27049e66a3296a132ee432ba83bd39c150ad | |
| parent | 79a392a3b19a106e0268bfbe1b4cc31d85eeb552 (diff) | |
| download | linux-65e5d27df61283e5390f04b09dc79cd832f95607.tar.gz | |
net: atlantic: fix potential memory leak in aq_ndev_close()
If aq_nic_stop() fails, aq_ndev_close() returns err without calling
aq_nic_deinit() to release the relevant memory and resource, which
will lead to a memory leak.
We can fix it by deleting the if condition judgment and goto statement to
call aq_nic_deinit() directly after aq_nic_stop() to fix the memory leak.
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_main.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_main.c b/drivers/net/ethernet/aquantia/atlantic/aq_main.c index 88595863d8bc6c..8a0af371e7dc7a 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_main.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_main.c @@ -94,11 +94,8 @@ static int aq_ndev_close(struct net_device *ndev) int err = 0; err = aq_nic_stop(aq_nic); - if (err < 0) - goto err_exit; aq_nic_deinit(aq_nic, true); -err_exit: return err; } |