diff options
| author | Zqiang <qiang.zhang1211@gmail.com> | 2024-01-17 18:26:16 +0800 |
|---|---|---|
| committer | Boqun Feng <boqun.feng@gmail.com> | 2024-02-14 07:50:45 -0800 |
| commit | f3c4c00784b5f7499d9cb6d31b661370c9a1ce7f (patch) | |
| tree | 5855cc1f374782ec3ae72e39f55677c4cafb6ebf | |
| parent | dda98810b552fc6bf650f4270edeebdc2f28bd3f (diff) | |
| download | linux-rcu-nocb.2024.02.14a.tar.gz | |
rcu/nocb: Check rdp_gp->nocb_timer in __call_rcu_nocb_wake()rcu-nocb.2024.02.14a
Currently, only rdp_gp->nocb_timer is used, for nocb_timer of
no-rdp_gp structure, the timer_pending() is always return false,
this commit therefore need to check rdp_gp->nocb_timer in
__call_rcu_nocb_wake().
Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
| -rw-r--r-- | kernel/rcu/tree_nocb.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index ffa69a5e18f4c2..f124d4d45ce641 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -564,6 +564,7 @@ static void __call_rcu_nocb_wake(struct rcu_data *rdp, bool was_alldone, long lazy_len; long len; struct task_struct *t; + struct rcu_data *rdp_gp = rdp->nocb_gp_rdp; // If we are being polled or there is no kthread, just leave. t = READ_ONCE(rdp->nocb_gp_kthread); @@ -608,7 +609,7 @@ static void __call_rcu_nocb_wake(struct rcu_data *rdp, bool was_alldone, smp_mb(); /* Enqueue before timer_pending(). */ if ((rdp->nocb_cb_sleep || !rcu_segcblist_ready_cbs(&rdp->cblist)) && - !timer_pending(&rdp->nocb_timer)) { + !timer_pending(&rdp_gp->nocb_timer)) { rcu_nocb_unlock(rdp); wake_nocb_gp_defer(rdp, RCU_NOCB_WAKE_FORCE, TPS("WakeOvfIsDeferred")); |