diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2023-05-03 19:06:34 +0200 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2023-08-10 16:00:49 +0200 |
| commit | c885ad66271c83d6fe63dabc3fc534d0ba4a33d6 (patch) | |
| tree | 294052e5e5b52a730351edaef65a83fbd3d4da21 | |
| parent | 8fc96723e861e064c89f7c09338969fd55638b6d (diff) | |
| download | playground-missing-prototypes-endgame-v1.tar.gz | |
[RFC] Makefile.extrawarn: turn on missing-prototypes againmissing-prototypes-endgame-v1
Over the years we went from > 1000 of warnings to under 100 earlier
this year, and I sent patches to address all the ones that I saw with
compile testing randcom configs on arm64, arm and x86 kernels. This is a
really useful warning, as it catches real bugs when there are mismatched
prototypes. In particular with kernel control flow integrity enabled,
those are no longer allowed.
Move the options out of the W=1 section to have them enabled by
default.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I'm sure there are still regressions with CONFIG_WERROR when this gets
turned on, but it's getting very close, so it might be best to already
enable this in linux-next but wait one extra merge window to have it in
mainline while the last fixes trickle in.
| -rw-r--r-- | scripts/Makefile.extrawarn | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 40cd13eca82e80..fda5f9087a8632 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -15,6 +15,9 @@ ifeq ("$(origin W)", "command line") KBUILD_EXTRA_WARN := $(W) endif +KBUILD_CFLAGS += -Wmissing-declarations +KBUILD_CFLAGS += -Wmissing-prototypes + export KBUILD_EXTRA_WARN # @@ -23,9 +26,7 @@ export KBUILD_EXTRA_WARN ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),) KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter -KBUILD_CFLAGS += -Wmissing-declarations KBUILD_CFLAGS += -Wmissing-format-attribute -KBUILD_CFLAGS += -Wmissing-prototypes KBUILD_CFLAGS += -Wold-style-definition KBUILD_CFLAGS += -Wmissing-include-dirs KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable) |