diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2020-09-20 22:37:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-09-21 14:49:14 -0700 |
| commit | a7920efdd86d8a0d74402dbc80ead03b023294ba (patch) | |
| tree | 4030bc863c859dbbaf3777310a5889b118af05bd | |
| parent | 0ce0c3cd2239502187ccfca3b46ab0344799ec4e (diff) | |
| download | bpf-next-a7920efdd86d8a0d74402dbc80ead03b023294ba.tar.gz | |
net: dsa: rtl8366rb: Support all 4096 VLANs
There is an off-by-one error in rtl8366rb_is_vlan_valid()
making VLANs 0..4094 valid while it should be 1..4095.
Fix it.
Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/dsa/rtl8366rb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c index ddc24f5e4123c8..a7ceffc2a70b4d 100644 --- a/drivers/net/dsa/rtl8366rb.c +++ b/drivers/net/dsa/rtl8366rb.c @@ -1318,7 +1318,7 @@ static bool rtl8366rb_is_vlan_valid(struct realtek_smi *smi, unsigned int vlan) if (smi->vlan4k_enabled) max = RTL8366RB_NUM_VIDS - 1; - if (vlan == 0 || vlan >= max) + if (vlan == 0 || vlan > max) return false; return true; |