aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorErik Schilling <erik.schilling@linaro.org>2023-06-16 10:37:48 +0200
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2023-06-19 10:09:40 +0200
commitd04639ddd11ed7d02c630e693bf07d97f53e17d3 (patch)
tree0651be06d131ba5707804617965476025d5ab616
parent06c8ad9ef9482892bf308a6919299285c5642952 (diff)
downloadlibgpiod-d04639ddd11ed7d02c630e693bf07d97f53e17d3.tar.gz
bindings: rust: bump MSRV to 1.60
Specifying MSRV (minimum supported rust version) was introduced with Rust 1.56. So old versions of libraries do not have this restriction spelled out in their Cargo.toml. This means that even if we claimed a MSRV of 1.56 until now, that did not mean that things were actually buildable with 1.56 practically (without manually researching compatible versions and pinning them down). `bindgen` started listing a MSRV from v0.61 (requiring Rust 1.57) [1]. So that may seem like an obvious choice. But if one attempts to build it with such an old version one will realize that `log` only started requesting a MSRV with 0.4.19 (requesting Rust 1.60) [2]. Hence, we would either need to manually restrict log to an old, but compatible release (which would unnecessarily restrict everyone on newer Rust versions) or just also bump our MSRV to 1.60. Rust 1.60 was released on 2022-04-07 [3] and seems like an acceptable choice if core components such as `log` started their MSRV tracking with that version. If someone is determined wanting to use this with an older version of Rust, thats still possible. If one has done the necessary manual research and pinned their versions down, one can use --ignore-rust-version (or a < 1.56 version of Rust that does not check the MSRV yet). Thanks to Manos Pitsidianakis <manos.pitsidianakis@linaro.org> for helping me out when I successfully confused myself somewhere. [1] https://github.com/rust-lang/rust-bindgen/blob/v0.61.0/bindgen/Cargo.toml [2] https://github.com/rust-lang/log/blob/0.4.19/Cargo.toml [3] https://blog.rust-lang.org/2022/04/07/Rust-1.60.0.html Signed-off-by: Erik Schilling <erik.schilling@linaro.org> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
-rw-r--r--bindings/rust/gpiosim-sys/Cargo.toml2
-rw-r--r--bindings/rust/libgpiod-sys/Cargo.toml2
-rw-r--r--bindings/rust/libgpiod/Cargo.toml2
3 files changed, 3 insertions, 3 deletions
diff --git a/bindings/rust/gpiosim-sys/Cargo.toml b/bindings/rust/gpiosim-sys/Cargo.toml
index af307486..1f44a312 100644
--- a/bindings/rust/gpiosim-sys/Cargo.toml
+++ b/bindings/rust/gpiosim-sys/Cargo.toml
@@ -9,7 +9,7 @@ authors = ["Viresh Kumar <viresh.kumar@linaro.org>"]
description = "gpiosim header bindings"
repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git"
categories = ["external-ffi-bindings", "os::linux-apis"]
-rust-version = "1.56"
+rust-version = "1.60"
keywords = ["libgpiod", "gpio", "gpiosim"]
license = "Apache-2.0 OR BSD-3-Clause"
edition = "2021"
diff --git a/bindings/rust/libgpiod-sys/Cargo.toml b/bindings/rust/libgpiod-sys/Cargo.toml
index 0c814eec..b4d26e91 100644
--- a/bindings/rust/libgpiod-sys/Cargo.toml
+++ b/bindings/rust/libgpiod-sys/Cargo.toml
@@ -9,7 +9,7 @@ authors = ["Viresh Kumar <viresh.kumar@linaro.org>"]
description = "libgpiod public header bindings"
repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git"
categories = ["external-ffi-bindings", "os::linux-apis"]
-rust-version = "1.56"
+rust-version = "1.60"
keywords = ["libgpiod", "gpio"]
license = "Apache-2.0 OR BSD-3-Clause"
edition = "2021"
diff --git a/bindings/rust/libgpiod/Cargo.toml b/bindings/rust/libgpiod/Cargo.toml
index d6758be4..518e5e56 100644
--- a/bindings/rust/libgpiod/Cargo.toml
+++ b/bindings/rust/libgpiod/Cargo.toml
@@ -9,7 +9,7 @@ authors = ["Viresh Kumar <viresh.kumar@linaro.org>"]
description = "libgpiod wrappers"
repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git"
categories = ["api-bindings", "hardware-support", "embedded", "os::linux-apis"]
-rust-version = "1.56"
+rust-version = "1.60"
keywords = ["libgpiod", "gpio"]
license = "Apache-2.0 OR BSD-3-Clause"
edition = "2021"