diff options
| author | Frantisek Sumsal <frantisek@sumsal.cz> | 2021-11-12 21:43:12 +0100 |
|---|---|---|
| committer | Jóhann B. Guðmundsson <johannbg@gmail.com> | 2021-11-15 11:37:22 +0000 |
| commit | 3f56d481e8a3c67c2e795686e6ec3bfc4ea08e1d (patch) | |
| tree | 7beec072c46a58542ba32338253edab7d2b40466 | |
| parent | 5c2f72f152ec319a8001d1ff0bfd1f81a9130b04 (diff) | |
| download | dracut-3f56d481e8a3c67c2e795686e6ec3bfc4ea08e1d.tar.gz | |
test: don't use `-cpu max` in GH Actions
There appears to be an issue with newer QEMU versions (spotted with Arch
Linux and C9S containers) which causes the respective GH Action to hang
when booting a QEMU VM in combination with the `-cpu max` parameter.
During (a particularly painful) debugging session I once managed to get
some output from such "frozen" machine (using `earlycon` and
`earlyprintk` kernel cmdline options), and in that particular case the
VM died with a trap caused by an invalid opcode.
I couldn't reproduce this locally, only in GH Actions environment with
Arch Linux and C9S containers. Also, so far I haven't found out which
specific CPUID flag causes this, but using the `IvyBridge-v2` feature
set seems to mitigate the issue.
| -rwxr-xr-x | test/run-qemu | 5 | ||||
| -rwxr-xr-x | tools/test-github.sh | 1 |
2 files changed, 4 insertions, 2 deletions
diff --git a/test/run-qemu b/test/run-qemu index 3c521a14..5dc61037 100755 --- a/test/run-qemu +++ b/test/run-qemu @@ -3,13 +3,14 @@ # We prefer kvm, kqemu, userspace in that order. export PATH=/usr/sbin:/usr/bin:/sbin:/bin +QEMU_CPU="${QEMU_CPU:-max}" -[[ -x /usr/bin/qemu ]] && BIN=/usr/bin/qemu && ARGS=(-cpu max) +[[ -x /usr/bin/qemu ]] && BIN=/usr/bin/qemu && ARGS=(-cpu "$QEMU_CPU") (lsmod | grep -q '^kqemu ') && BIN=/usr/bin/qemu && ARGS=(-kernel-kqemu -cpu host) [[ -c /dev/kvm && -x /usr/bin/kvm ]] && BIN=/usr/bin/kvm && ARGS=(-cpu host) [[ -c /dev/kvm && -x /usr/bin/qemu-kvm ]] && BIN=/usr/bin/qemu-kvm && ARGS=(-cpu host) [[ -c /dev/kvm && -x /usr/libexec/qemu-kvm ]] && BIN=/usr/libexec/qemu-kvm && ARGS=(-cpu host) -[[ -x /usr/bin/qemu-system-$(uname -m) ]] && BIN=/usr/bin/qemu-system-$(uname -m) && ARGS=(-cpu max) +[[ -x /usr/bin/qemu-system-$(uname -m) ]] && BIN=/usr/bin/qemu-system-$(uname -m) && ARGS=(-cpu "$QEMU_CPU") [[ -c /dev/kvm && -x /usr/bin/qemu-system-$(uname -m) ]] && BIN=/usr/bin/qemu-system-$(uname -m) && ARGS=(-enable-kvm -cpu host) [[ $BIN ]] || { diff --git a/tools/test-github.sh b/tools/test-github.sh index eab59dcc..1d61b8e3 100755 --- a/tools/test-github.sh +++ b/tools/test-github.sh @@ -41,6 +41,7 @@ else cd /lib/modules ls -1 | tail -1 )" \ + QEMU_CPU="IvyBridge-v2" \ DRACUT_NO_XATTR=1 \ TEST_RUN_ID="$RUN_ID" \ ${TESTS:+TESTS="$TESTS"} \ |