aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/tools
diff options
context:
space:
mode:
authorBastien Nocera <hadess@hadess.net>2024-05-10 14:10:26 +0200
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>2024-05-10 11:29:01 -0400
commitc81f9320357b0808dd4debebc687d26dc0be30ab (patch)
tree0b2f1c69fe4bbb31c12b172ff2e3ed6a3f66e9aa /tools
parent3e03788ba80c94888d9e78bf1c8f62fff42353b8 (diff)
iso-tester: Fix fd leak
Error: RESOURCE_LEAK (CWE-772): [#def63] [important] tools/iso-tester.c:1796:2: open_fn: Returning handle opened by "socket". tools/iso-tester.c:1796:2: var_assign: Assigning: "sk" = handle returned from "socket(31, 2053, 8)". tools/iso-tester.c:1807:3: leaked_handle: Handle variable "sk" going out of scope leaks the handle. 1805| if (!master_bdaddr) { 1806| tester_warn("No master bdaddr"); 1807|-> return -ENODEV; 1808| } 1809|
Diffstat (limited to 'tools')
-rw-r--r--tools/iso-tester.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index 0466060682..d54fa56ecd 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -1804,6 +1804,7 @@ static int create_iso_sock(struct test_data *data)
master_bdaddr = hciemu_get_central_bdaddr(data->hciemu);
if (!master_bdaddr) {
tester_warn("No master bdaddr");
+ close(sk);
return -ENODEV;
}