aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYordan Karadzhov (VMware) <y.karadz@gmail.com>2021-07-27 16:42:25 +0300
committerYordan Karadzhov (VMware) <y.karadz@gmail.com>2021-07-28 11:04:24 +0300
commitb8e70a5459d6da289056595506ab82357dcbd918 (patch)
tree723f885e8da240d240fd3a3868d6b13a721202dd
parent3b94c3a6ff7a9110c46a215f6407d7f619a4090d (diff)
downloadkernel-shark-b8e70a5459d6da289056595506ab82357dcbd918.tar.gz
kernel-shark: Fix warnings from deprecated Qt APIs
Couple of APIs used by KernelShark have been marked as deprecated in the recent version of Qt. Fix all compilation warnings caused by the usage of these deprecated APIs. Link: https://lore.kernel.org/linux-trace-devel/20210727134225.25025-2-y.karadz@gmail.com Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
-rw-r--r--CMakeLists.txt6
-rw-r--r--build/deff.h.cmake1
-rw-r--r--src/KsGLWidget.cpp12
-rw-r--r--src/KsUtils.cpp6
-rw-r--r--src/KsUtils.hpp10
-rw-r--r--src/kernelshark.cpp2
6 files changed, 31 insertions, 6 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 67dfb816..c2c09833 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -83,6 +83,12 @@ if (Qt5Widgets_FOUND)
endif()
+ if(Qt5Widgets_VERSION VERSION_LESS "5.15")
+
+ set(QT_VERSION_LESS_5_15 TRUE)
+
+ endif()
+
endif (Qt5Widgets_FOUND)
find_package (Boost COMPONENTS unit_test_framework)
diff --git a/build/deff.h.cmake b/build/deff.h.cmake
index 06cbf16c..82379df4 100644
--- a/build/deff.h.cmake
+++ b/build/deff.h.cmake
@@ -31,6 +31,7 @@
/** Qt - old version detected. */
#cmakedefine QT_VERSION_LESS_5_11
+#cmakedefine QT_VERSION_LESS_5_15
/** Location of the KernelShark tests. */
#cmakedefine KS_TEST_DIR "@KS_TEST_DIR@"
diff --git a/src/KsGLWidget.cpp b/src/KsGLWidget.cpp
index 8aab7b3c..3b2e0d4d 100644
--- a/src/KsGLWidget.cpp
+++ b/src/KsGLWidget.cpp
@@ -345,10 +345,18 @@ void KsGLWidget::wheelEvent(QWheelEvent * event)
* Use the position of the mouse as a focus point for the
* zoom.
*/
- zoomFocus = event->pos().x() - _bin0Offset();
+#ifdef QT_VERSION_LESS_5_15
+
+ zoomFocus = event->pos().x() - _bin0Offset();
+
+#else
+
+ zoomFocus = event->position().x() - _bin0Offset();
+
+#endif // QT_VERSION_LESS_5_15
}
- if (event->delta() > 0) {
+ if (event->angleDelta().y() > 0) {
_model.zoomIn(.05, zoomFocus);
} else {
_model.zoomOut(.05, zoomFocus);
diff --git a/src/KsUtils.cpp b/src/KsUtils.cpp
index 3db89510..364c25db 100644
--- a/src/KsUtils.cpp
+++ b/src/KsUtils.cpp
@@ -486,7 +486,7 @@ QString getSaveFile(QWidget *parent,
*/
QStringList splitArguments(QString cmd)
{
- QString::SplitBehavior opt = QString::SkipEmptyParts;
+ auto opt = KS_SPLIT_SkipEmptyParts;
int i, progress = 0, size;
QStringList argv;
QChar quote = 0;
@@ -527,7 +527,7 @@ QStringList splitArguments(QString cmd)
*/
QVector<int> parseIdList(QString v_str)
{
- QStringList list = v_str.split(",", QString::SkipEmptyParts);
+ QStringList list = v_str.split(",", KS_SPLIT_SkipEmptyParts);
QVector<int> v;
for (auto item: list) {
@@ -553,7 +553,7 @@ QVector<int> parseIdList(QString v_str)
*/
QMap<int, QVector<int>> parseTaskList(QString v_str)
{
- QStringList taskList = v_str.split(",", QString::SkipEmptyParts);
+ QStringList taskList = v_str.split(",", KS_SPLIT_SkipEmptyParts);
QVector<int> streamIds, allPids;
kshark_context *kshark_ctx(nullptr);
QMap<int, QVector<int>> ret;
diff --git a/src/KsUtils.hpp b/src/KsUtils.hpp
index cf209bce..1a97d9ea 100644
--- a/src/KsUtils.hpp
+++ b/src/KsUtils.hpp
@@ -86,6 +86,16 @@ typedef std::chrono::high_resolution_clock::time_point hd_time;
std::chrono::duration_cast<std::chrono::duration<double>>( \
std::chrono::high_resolution_clock::now() - t0).count()
+#ifdef QT_VERSION_LESS_5_15
+
+ #define KS_SPLIT_SkipEmptyParts QString::SkipEmptyParts
+
+#else
+
+ #define KS_SPLIT_SkipEmptyParts Qt::SkipEmptyParts
+
+#endif // QT_VERSION_LESS_5_15
+
//! @endcond
namespace KsUtils {
diff --git a/src/kernelshark.cpp b/src/kernelshark.cpp
index 8ed49480..92bc1f1e 100644
--- a/src/kernelshark.cpp
+++ b/src/kernelshark.cpp
@@ -87,7 +87,7 @@ int main(int argc, char **argv)
break;
case 'a':
- appInputFiles << QString(optarg).split(" ", QString::SkipEmptyParts);
+ appInputFiles << QString(optarg).split(" ", KS_SPLIT_SkipEmptyParts);
break;
case 'p':