diff options
| author | Benjamin ROBIN <dev@benjarobin.fr> | 2024-01-14 18:16:53 +0100 |
|---|---|---|
| committer | Yordan Karadzhov <y.karadz@gmail.com> | 2024-02-04 19:52:05 +0200 |
| commit | 4f3bc9bb1fc0ebd295882d9d1331fb6de7867c0f (patch) | |
| tree | b731f4c4ec7d00ea73fd3ac2a31aab9eb19c447b | |
| parent | e892dc5e34244276f67c73905f858ced8f818aef (diff) | |
| download | kernel-shark-4f3bc9bb1fc0ebd295882d9d1331fb6de7867c0f.tar.gz | |
kernelshark: Do not create a temporary container for looping over QMap
Use const_iterator instead. Fix container-anti-pattern Clazy warning
Signed-off-by: Benjamin ROBIN <dev@benjarobin.fr>
Signed-off-by: Yordan Karadzhov <y.karadz@gmail.com>
| -rw-r--r-- | src/KsAdvFilteringDialog.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/KsAdvFilteringDialog.cpp b/src/KsAdvFilteringDialog.cpp index 3ebde22b..c0d6d48c 100644 --- a/src/KsAdvFilteringDialog.cpp +++ b/src/KsAdvFilteringDialog.cpp @@ -276,8 +276,8 @@ void KsAdvFilteringDialog::_makeFilterTable() headers << "Delete" << "Stream" << "Event" << " Id" << "Filter"; _table->init(headers, _filters.count()); - for(auto f : _filters.keys()) { - QStringList thisFilter = _filters.value(f).split(":"); + for (auto it = _filters.cbegin(), end = _filters.cend(); it != end; ++it) { + QStringList thisFilter = it.value().split(":"); i1 = new QTableWidgetItem(thisFilter[0]); _table->setItem(count, 1, i1); @@ -285,7 +285,7 @@ void KsAdvFilteringDialog::_makeFilterTable() i1 = new QTableWidgetItem(thisFilter[1]); _table->setItem(count, 2, i1); - i2 = new QTableWidgetItem(tr("%1").arg(f)); + i2 = new QTableWidgetItem(tr("%1").arg(it.key())); _table->setItem(count, 3, i2); i3 = new QTableWidgetItem(thisFilter[2]); |