diff options
| author | Michal Sojka <michal.sojka@cvut.cz> | 2021-03-17 17:41:01 +0100 |
|---|---|---|
| committer | Yordan Karadzhov (VMware) <y.karadz@gmail.com> | 2021-03-22 17:19:54 +0200 |
| commit | 47a7e9f4db8a9f168010b7bbf03c2a3000c51339 (patch) | |
| tree | da9e39d27eedfe4fac7264e8a6503edce6ff666b | |
| parent | c09344da7b28e50c49c63f790f6267ac16dbd4e1 (diff) | |
| download | kernel-shark-47a7e9f4db8a9f168010b7bbf03c2a3000c51339.tar.gz | |
kernel-shark: Do not use sudo in install_gui.sh + update README
Using `make install` to install kernelshark can lead to errors
described in the previous commit. Therefore, we instruct users to use
the provided script install_gui.sh. We update the script not to use
sudo, because it's preferable if users give root privileges explicitly
via command line.
Link: https://lore.kernel.org/linux-trace-devel/20210317164101.30848-5-michal.sojka@cvut.cz
Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
| -rw-r--r-- | README | 2 | ||||
| -rwxr-xr-x | build/install_gui.sh | 4 |
2 files changed, 3 insertions, 3 deletions
@@ -51,7 +51,7 @@ Building: cd kernel-shark/build cmake ../ make - sudo make install + sudo ./install_gui.sh 2.1 In order to create a Doxygen documentation add -D_DOXYGEN_DOC=1 as a CMake Command-Line option. diff --git a/build/install_gui.sh b/build/install_gui.sh index d262f791..c42f4da8 100755 --- a/build/install_gui.sh +++ b/build/install_gui.sh @@ -1,9 +1,9 @@ -if sudo cmake -DCOMPONENT=kernelshark -P cmake_install.cmake; then +if cmake -DCOMPONENT=kernelshark -P cmake_install.cmake; then echo "Kernelshark installed correctly" else exit 1 fi -if ! sudo cmake -DCOMPONENT=polkit-policy -P cmake_install.cmake; then +if ! cmake -DCOMPONENT=polkit-policy -P cmake_install.cmake; then echo >&2 "Warning: polkit policy not installed" fi |