aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Kacur <jkacur@redhat.com>2022-01-13 13:22:16 -0500
committerJohn Kacur <jkacur@redhat.com>2022-01-13 13:22:16 -0500
commitc77226a9754f0016ebf24981b9970b4184e5e84c (patch)
tree56697c1e64d1008710fa518cf4efcf68f4cedf2c
parentb902c41fe1688cb767974a5cc6ca337e5ec420e0 (diff)
downloadrteval-c77226a9754f0016ebf24981b9970b4184e5e84c.tar.gz
rteval: Don't run hackbench by default on low memory systems
commit cb8263770e4f5834a43db6be8ffb55ffd7f876c9 Changed rteval to allow running on low memory systems by default because on some machines, such as certain Arm boards, it isn't a problem. However, on our automated testing systems it is causing problems. This patch disables running hackbench by default on a low memory system. In order to allow people to run on a lowmem system where this isn't a problem, this patch also creates the option --hackbench-runlowmem=True|False A user who wants hackbench to run in rteval on a low memory system, only needs to specify --hackbench-runlowmem=True Signed-off-by: John Kacur <jkacur@redhat.com>
-rw-r--r--rteval/modules/loads/hackbench.py10
1 files changed, 9 insertions, 1 deletions
diff --git a/rteval/modules/loads/hackbench.py b/rteval/modules/loads/hackbench.py
index 21a803b..ddd1378 100644
--- a/rteval/modules/loads/hackbench.py
+++ b/rteval/modules/loads/hackbench.py
@@ -39,6 +39,7 @@ from rteval.systopology import SysTopology
class Hackbench(CommandLineLoad):
def __init__(self, config, logger):
+ self.__cfg = config
CommandLineLoad.__init__(self, "hackbench", config, logger)
def _WorkloadSetup(self):
@@ -56,7 +57,11 @@ class Hackbench(CommandLineLoad):
ratio = float(mem) / float(self.num_cpus)
if ratio < 0.75:
- self._log(Log.WARN, "Low memory system (%f GB/core)!" % ratio)
+ if self.__cfg.runlowmem:
+ self._log(Log.WARN, "Low memory system (%f GB/core)!" % ratio)
+ else:
+ self._log(Log.WARN, "Low memory system (%f GB/core)! Not running hackbench" % ratio)
+ self._donotrun = True
sysTop = SysTopology()
# get the number of nodes
@@ -198,6 +203,9 @@ def ModuleParameters():
return {"jobspercore": {"descr": "Number of working threads per CPU core",
"default": 5,
"metavar": "NUM"},
+ "runlowmem": {"descr": "Run hackbench on machines where low memory is detected",
+ "default": False,
+ "metavar": "True|False"}
}