diff options
| author | Andy Lutomirski <luto@kernel.org> | 2015-12-07 11:21:43 -0800 |
|---|---|---|
| committer | Andy Lutomirski <luto@kernel.org> | 2015-12-07 11:25:26 -0800 |
| commit | 2cf2cd60d4dcc96fe06b46542bb2af1e15fa82ee (patch) | |
| tree | f8d14fc55b958551480f96c401e8e09ec6e8b526 | |
| parent | 17363c2900e8b796c80c920c6fcdcc6747784ef7 (diff) | |
| download | virtme-2cf2cd60d4dcc96fe06b46542bb2af1e15fa82ee.tar.gz | |
Disable uevent_helper (compile-time and runtime) and warn about it
It's slow, and it triggers a lockup under some circumstances.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
| -rw-r--r-- | virtme/commands/configkernel.py | 1 | ||||
| -rwxr-xr-x | virtme/guest/virtme-init | 9 |
2 files changed, 10 insertions, 0 deletions
diff --git a/virtme/commands/configkernel.py b/virtme/commands/configkernel.py index 4d2946c..0da6fab 100644 --- a/virtme/commands/configkernel.py +++ b/virtme/commands/configkernel.py @@ -46,6 +46,7 @@ def arg_fail(message): _GENERIC_CONFIG = [ '# Generic', + 'CONFIG_UEVENT_HELPER=n', # Obsolete and slow 'CONFIG_VIRTIO=y', 'CONFIG_VIRTIO_PCI=y', 'CONFIG_VIRTIO_MMIO=y', diff --git a/virtme/guest/virtme-init b/virtme/guest/virtme-init index b85054e..cfff41a 100755 --- a/virtme/guest/virtme-init +++ b/virtme/guest/virtme-init @@ -88,9 +88,18 @@ log "basic initialization done" # Try to get udevd to coldplug everything. # We could use virtme-loadmods as a lightweight alternative. if [[ -n "$udevd" ]]; then + if [[ -e '/sys/kernel/uevent_helper' ]]; then + # This kills boot performance. + log "you have CONFIG_UEVENT_HELPER on; turn it off" + echo '' >/sys/kernel/uevent_helper + fi + log "starting udevd" "$udevd" --daemon --resolve-names=never + log "triggering udev coldplug" udevadm trigger --action=add >/dev/null 2>&1 + log "waiting for udev to settle" udevadm settle + log "udev is done" else log "udevd not found" fi |