aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlan Jenkins <alan-jenkins@tuffmail.co.uk>2010-03-16 11:22:40 +0000
committerAlan Jenkins <alan-jenkins@tuffmail.co.uk>2010-03-17 10:24:57 +0000
commit95ff1ab26c50f25ba39683878148b86d644eb693 (patch)
treeb11e81f319d2205f3e6e7219d403e3630282ae6f
parent9a3215f20ffe8fbdd941b2c057d3a97b30b22b6d (diff)
downloadmodule-init-tools-95ff1ab26c50f25ba39683878148b86d644eb693.tar.gz
modprobe: fix dump_config
I broke this when refactoring the config handling. --show-config ended up printing the contents of user config files twice. Also parse_kcmdline() was always called with dump_only=1, regardless of whether --show-config was requested.
-rw-r--r--modprobe.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/modprobe.c b/modprobe.c
index d16151a..47f3a9b 100644
--- a/modprobe.c
+++ b/modprobe.c
@@ -1894,7 +1894,7 @@ int main(int argc, char *argv[])
parse_toplevel_config(configname, &conf, dump_config, flags & mit_remove);
/* Read module options from kernel command line */
- parse_kcmdline(1, &conf.options);
+ parse_kcmdline(dump_config, &conf.options);
if (dump_config) {
char *aliasfilename, *symfilename;
@@ -1903,9 +1903,6 @@ int main(int argc, char *argv[])
nofail_asprintf(&aliasfilename, "%s/modules.alias", dirname);
nofail_asprintf(&symfilename, "%s/modules.symbols", dirname);
- parse_toplevel_config(configname, &conf, 1, 0);
- /* Read module options from kernel command line */
- parse_kcmdline(1, &conf.options);
read_aliases(aliasfilename, "", 1, &conf.aliases);
read_aliases(symfilename, "", 1, &conf.aliases);