aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndre Przywara <andre.przywara@arm.com>2020-10-12 17:19:45 +0100
committerDavid Gibson <david@gibson.dropbear.id.au>2020-10-13 15:58:53 +1100
commit3bc3a6b9fe0cba171bef7d1cc2b04a362228dd1c (patch)
tree36f5841ee39a755bc1ca02a0b6b504205b3d113e
parente1147b159e9209e1c3102f350445ba9927048b4d (diff)
downloaddtc-3bc3a6b9fe0cba171bef7d1cc2b04a362228dd1c.tar.gz
dtc: Fix signedness comparisons warnings: Wrap (-1)
With -Wsign-compare, compilers warn about a mismatching signedness in a comparison in dtc's data_copy_file(). Even though maxlen is of an unsigned type, we compare against "-1", which is passed in from the parser to indicate an unknown size. Cast the "-1" to an unsigned size to make the comparison match. Signed-off-by: Andre Przywara <andre.przywara@arm.com> Message-Id: <20201012161948.23994-9-andre.przywara@arm.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--data.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/data.c b/data.c
index fdb0407..1473423 100644
--- a/data.c
+++ b/data.c
@@ -84,7 +84,7 @@ struct data data_copy_file(FILE *f, size_t maxlen)
while (!feof(f) && (d.len < maxlen)) {
size_t chunksize, ret;
- if (maxlen == -1)
+ if (maxlen == (size_t)-1)
chunksize = 4096;
else
chunksize = maxlen - d.len;