summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorнаб <nabijaczleweli@nabijaczleweli.xyz>2023-02-07 20:33:30 +0100
committerHerbert Xu <herbert@gondor.apana.org.au>2024-04-06 16:53:03 +0800
commitf0d4a2eeaf3cd151a37453ff1cd94fcc7a7b10af (patch)
tree0e11bf10ba23d6fb590ad94add993f386e8a53b2
parentb9c069b0cc372821942aecd04829030f5710baac (diff)
downloaddash-f0d4a2eeaf3cd151a37453ff1cd94fcc7a7b10af.tar.gz
histedit: Fix fs -s infinite loop
$ id 1 uid=1(daemon) gid=1(daemon) groups=1(daemon) $ fc -s 2 fc -s 2 fc -s 2 fc -s 2 fc -s 2 src/dash: 1: fc: called recursively too many times and I'm happy to call this "behaving exactly as I expected when I was typing it in", so removing the XXX. Adapted-from: NetBSD src bin/sh/histedit.c rev 1.38 by aymeric@ Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--src/histedit.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/histedit.c b/src/histedit.c
index fc87283..28956ec 100644
--- a/src/histedit.c
+++ b/src/histedit.c
@@ -382,12 +382,10 @@ histcmd(int argc, char **argv)
evalstring(s, 0);
if (displayhist && hist) {
- /*
- * XXX what about recursive and
- * relative histnums.
- */
history(hist, &he, H_ENTER, s);
}
+
+ break;
} else
fputs(s, efp);
}