aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis Kenzior <denkenz@gmail.com>2024-02-29 11:42:28 -0600
committerDenis Kenzior <denkenz@gmail.com>2024-02-29 11:43:37 -0600
commit7f2adfa22fbae824f8e2c3ae86a3f51da31ee400 (patch)
tree01512fa53992929c8763dc3e6c6d2c02530ce982
parenta90421d8e45d63b304dc010baba24633e7869682 (diff)
downloadofono-7f2adfa22fbae824f8e2c3ae86a3f51da31ee400.tar.gz
smsutil: Check cbs_dcs_decode return value
It is better to explicitly check the return value of cbs_dcs_decode instead of relying on udhi not being changed due to side-effects.
-rw-r--r--src/smsutil.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/smsutil.c b/src/smsutil.c
index e89b4567f..6fe2bcb44 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -1765,7 +1765,8 @@ gboolean sms_udh_iter_init_from_cbs(const struct cbs *cbs,
const guint8 *hdr;
guint8 max_ud_len;
- cbs_dcs_decode(cbs->dcs, &udhi, NULL, NULL, NULL, NULL, NULL);
+ if (!cbs_dcs_decode(cbs->dcs, &udhi, NULL, NULL, NULL, NULL, NULL))
+ return FALSE;
if (!udhi)
return FALSE;