diff options
| author | Steve Schrock <steve.schrock@getcruise.com> | 2024-02-17 00:30:32 +0000 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2024-02-20 09:29:22 -0600 |
| commit | 00444ee7c8bf259467a40ad0696240fb3862abab (patch) | |
| tree | 9e0dddfe9aaad5337d7486b84356662068149569 | |
| parent | 6984ddd426945f96aa01173513c682853daefc95 (diff) | |
| download | ofono-00444ee7c8bf259467a40ad0696240fb3862abab.tar.gz | |
qmimodem: Fix checkpatch.pl warnings and errors
| -rw-r--r-- | drivers/qmimodem/qmi.c | 7 | ||||
| -rw-r--r-- | drivers/qmimodem/qmi.h | 12 |
2 files changed, 10 insertions, 9 deletions
diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c index 3c8c00a69..c9c809757 100644 --- a/drivers/qmimodem/qmi.c +++ b/drivers/qmimodem/qmi.c @@ -299,6 +299,7 @@ static void __hexdump(const char dir, const unsigned char *buf, size_t len, if (i % 16 > 0) { size_t j; + for (j = (i % 16); j < 16; j++) { str[(j * 3) + 1] = ' '; str[(j * 3) + 2] = ' '; @@ -720,6 +721,7 @@ static uint16_t __request_submit(struct qmi_device *device, req->tid = hdr->transaction; } else { struct qmi_service_hdr *hdr; + hdr = req->buf + QMI_MUX_HDR_SIZE; hdr->type = 0x00; hdr->transaction = device->next_service_tid++; @@ -1142,9 +1144,8 @@ bool qmi_device_has_service(struct qmi_device *device, uint16_t type) for (i = 0, info = device->version_list; i < device->version_count; i++, info++) { - if (info->type == type) { + if (info->type == type) return true; - } } return false; @@ -2260,7 +2261,7 @@ void qmi_service_unref(struct qmi_service *service) unsigned int hash_id; if (!service) - return; + return; if (__sync_sub_and_fetch(&service->ref_count, 1)) return; diff --git a/drivers/qmimodem/qmi.h b/drivers/qmimodem/qmi.h index 3fdf960b9..21537a76c 100644 --- a/drivers/qmimodem/qmi.h +++ b/drivers/qmimodem/qmi.h @@ -62,12 +62,12 @@ enum qmi_device_expected_data_format { }; enum qmi_data_endpoint_type { - QMI_DATA_ENDPOINT_TYPE_UNKNOWN = 0x00, - QMI_DATA_ENDPOINT_TYPE_HSIC = 0x01, - QMI_DATA_ENDPOINT_TYPE_HSUSB = 0x02, - QMI_DATA_ENDPOINT_TYPE_PCIE = 0x03, - QMI_DATA_ENDPOINT_TYPE_EMBEDDED = 0x04, - QMI_DATA_ENDPOINT_TYPE_BAM_DMUX = 0x05, + QMI_DATA_ENDPOINT_TYPE_UNKNOWN = 0x00, + QMI_DATA_ENDPOINT_TYPE_HSIC = 0x01, + QMI_DATA_ENDPOINT_TYPE_HSUSB = 0x02, + QMI_DATA_ENDPOINT_TYPE_PCIE = 0x03, + QMI_DATA_ENDPOINT_TYPE_EMBEDDED = 0x04, + QMI_DATA_ENDPOINT_TYPE_BAM_DMUX = 0x05, }; void qmi_free(void *ptr); |