diff options
author | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2019-06-05 09:27:55 -0400 |
---|---|---|
committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2019-06-05 09:27:55 -0400 |
commit | b43f658c37188c55af2e8e84e0086e1e217d2ab1 (patch) | |
tree | f251f32bdf65fbc6f60d1f0a7d94102077b23742 | |
parent | c2fc2bc296f7cf59a6614f942880d0060ac4178e (diff) | |
parent | b1118fa0b8fde801f203df021e4e83a5be0644ab (diff) | |
download | trace-cmd-b43f658c37188c55af2e8e84e0086e1e217d2ab1.tar.gz |
Merge remote-tracking branch 'yordan/master' into trace-cmd
Yordan Karadzhov (2):
kernel-shark: Add new dataloading method to be used by the NumPu interface
kernel-shark: Use full paths for non-standard library headers
-rw-r--r-- | include/trace-cmd/trace-cmd.h | 2 | ||||
-rw-r--r-- | include/traceevent/event-parse.h | 2 | ||||
-rw-r--r-- | kernel-shark/CMakeLists.txt | 3 | ||||
-rw-r--r-- | kernel-shark/build/FindTraceCmd.cmake | 44 | ||||
-rw-r--r-- | kernel-shark/src/libkshark-plugin.h | 2 | ||||
-rw-r--r-- | kernel-shark/src/libkshark.c | 139 | ||||
-rw-r--r-- | kernel-shark/src/libkshark.h | 16 |
7 files changed, 172 insertions, 36 deletions
diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index ceb03f49..9320098b 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -6,7 +6,7 @@ #ifndef _TRACE_CMD_H #define _TRACE_CMD_H -#include "event-parse.h" +#include "traceevent/event-parse.h" #define ARRAY_SIZE(_a) (sizeof(_a) / sizeof((_a)[0])) #define __weak __attribute__((weak)) diff --git a/include/traceevent/event-parse.h b/include/traceevent/event-parse.h index 5e0fd19a..65cabd91 100644 --- a/include/traceevent/event-parse.h +++ b/include/traceevent/event-parse.h @@ -12,7 +12,7 @@ #include <regex.h> #include <string.h> -#include "trace-seq.h" +#include "traceevent/trace-seq.h" #ifndef __maybe_unused #define __maybe_unused __attribute__((unused)) diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt index 52e4a296..145b0582 100644 --- a/kernel-shark/CMakeLists.txt +++ b/kernel-shark/CMakeLists.txt @@ -56,8 +56,7 @@ SET(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE) include_directories(${KS_DIR}/src/ ${KS_DIR}/build/src/ ${JSONC_INCLUDE_DIR} - ${TRACECMD_INCLUDE_DIR} - ${TRACEEVENT_INCLUDE_DIR}) + ${TRACECMD_INCLUDE_DIR}) message("") message(STATUS "C flags : " ${CMAKE_C_FLAGS}) diff --git a/kernel-shark/build/FindTraceCmd.cmake b/kernel-shark/build/FindTraceCmd.cmake index b09a11b3..8c51f111 100644 --- a/kernel-shark/build/FindTraceCmd.cmake +++ b/kernel-shark/build/FindTraceCmd.cmake @@ -2,13 +2,10 @@ # This module finds an installed trace-cmd package. # # It sets the following variables: -# TRACEEVENT_INCLUDE_DIR, where to find traceevent header. -# TRACEEVENT_LIBRARY_DIR , where to find the traceevent library. # TRACEEVENT_LIBRARY, traceevent the library. # TRACEEVENT_FOUND, If false, do not try to use traceevent. # # TRACECMD_INCLUDE_DIR, where to find trace-cmd header. -# TRACECMD_LIBRARY_DIR , where to find the trace-cmd library. # TRACECMD_LIBRARY, the trace-cmd library. # TRACECMD_FOUND, If false, do not try to use trace-cmd. @@ -20,28 +17,33 @@ find_path(TRACECMD_BIN_DIR NAMES trace-cmd ${CMAKE_SOURCE_DIR}/../tracecmd/ NO_DEFAULT_PATH) -find_path(TRACECMD_INCLUDE_DIR NAMES trace-cmd.h - PATHS $ENV{TRACE_CMD}/include/trace-cmd/ - ${CMAKE_SOURCE_DIR}/../include/trace-cmd/ +find_path(TRACECMD_INCLUDE_DIR NAMES trace-cmd/trace-cmd.h + PATHS $ENV{TRACE_CMD}/include/ + ${CMAKE_SOURCE_DIR}/../include/ NO_DEFAULT_PATH) -find_path(TRACECMD_LIBRARY_DIR NAMES libtracecmd.a - PATHS $ENV{TRACE_CMD}/lib/trace-cmd/ - ${CMAKE_SOURCE_DIR}/../lib/trace-cmd/ +find_library(TRACECMD_LIBRARY NAMES trace-cmd/libtracecmd.a + PATHS $ENV{TRACE_CMD}/lib/ + ${CMAKE_SOURCE_DIR}/../lib/ + NO_DEFAULT_PATH) + +find_library(TRACEEVENT_LIBRARY NAMES traceevent/libtraceevent.a + PATHS $ENV{TRACE_CMD}/lib/ + ${CMAKE_SOURCE_DIR}/../lib/ NO_DEFAULT_PATH) # If not found, search in the default system paths. Note that if the previous # search was successful "find_path" will do nothing this time. find_path(TRACECMD_BIN_DIR NAMES trace-cmd) -find_path(TRACECMD_INCLUDE_DIR NAMES trace-cmd.h) -find_path(TRACECMD_LIBRARY_DIR NAMES libtracecmd.a) +find_path(TRACECMD_INCLUDE_DIR NAMES trace-cmd/trace-cmd.h) +find_library(TRACECMD_LIBRARY NAMES trace-cmd/libtracecmd.so) +find_library(TRACEEVENT_LIBRARY NAMES traceevent/libtraceevent.so) -IF (TRACECMD_INCLUDE_DIR AND TRACECMD_LIBRARY_DIR) +IF (TRACECMD_INCLUDE_DIR AND TRACECMD_LIBRARY) SET(TRACECMD_FOUND TRUE) - SET(TRACECMD_LIBRARY "${TRACECMD_LIBRARY_DIR}/libtracecmd.a") -ENDIF (TRACECMD_INCLUDE_DIR AND TRACECMD_LIBRARY_DIR) +ENDIF (TRACECMD_INCLUDE_DIR AND TRACECMD_LIBRARY) IF (TRACECMD_FOUND) @@ -53,21 +55,11 @@ ELSE (TRACECMD_FOUND) ENDIF (TRACECMD_FOUND) - -find_path(TRACEEVENT_INCLUDE_DIR NAMES event-parse.h - PATHS $ENV{TRACE_CMD}/include/traceevent/ - ${CMAKE_SOURCE_DIR}/../include/traceevent/) - -find_path(TRACEEVENT_LIBRARY_DIR NAMES libtraceevent.a - PATHS $ENV{TRACE_CMD}/lib/traceevent/ - ${CMAKE_SOURCE_DIR}/../lib/traceevent/) - -IF (TRACEEVENT_INCLUDE_DIR AND TRACEEVENT_LIBRARY_DIR) +IF (TRACEEVENT_LIBRARY) SET(TRACEEVENT_FOUND TRUE) - SET(TRACEEVENT_LIBRARY "${TRACEEVENT_LIBRARY_DIR}/libtraceevent.a") -ENDIF (TRACEEVENT_INCLUDE_DIR AND TRACEEVENT_LIBRARY_DIR) +ENDIF (TRACEEVENT_LIBRARY) IF (TRACEEVENT_FOUND) diff --git a/kernel-shark/src/libkshark-plugin.h b/kernel-shark/src/libkshark-plugin.h index 0cb677aa..b3cf1c62 100644 --- a/kernel-shark/src/libkshark-plugin.h +++ b/kernel-shark/src/libkshark-plugin.h @@ -17,7 +17,7 @@ extern "C" { #endif // __cplusplus // trace-cmd -#include "event-parse.h" +#include "traceevent/event-parse.h" /* Quiet warnings over documenting simple structures */ //! @cond Doxygen_Suppress diff --git a/kernel-shark/src/libkshark.c b/kernel-shark/src/libkshark.c index 175279c5..0f0a1bab 100644 --- a/kernel-shark/src/libkshark.c +++ b/kernel-shark/src/libkshark.c @@ -957,6 +957,145 @@ ssize_t kshark_load_data_records(struct kshark_context *kshark_ctx, return -ENOMEM; } +static inline void free_ptr(void *ptr) +{ + if (ptr) + free(*(void **)ptr); +} + +static bool data_matrix_alloc(size_t n_rows, uint64_t **offset_array, + uint16_t **cpu_array, + uint64_t **ts_array, + uint16_t **pid_array, + int **event_array) +{ + if (offset_array) { + *offset_array = calloc(n_rows, sizeof(**offset_array)); + if (!*offset_array) + return false; + } + + if (cpu_array) { + *cpu_array = calloc(n_rows, sizeof(**cpu_array)); + if (!*cpu_array) + goto free_offset; + } + + if (ts_array) { + *ts_array = calloc(n_rows, sizeof(**ts_array)); + if (!*ts_array) + goto free_cpu; + } + + if (pid_array) { + *pid_array = calloc(n_rows, sizeof(**pid_array)); + if (!*pid_array) + goto free_ts; + } + + if (event_array) { + *event_array = calloc(n_rows, sizeof(**event_array)); + if (!*event_array) + goto free_pid; + } + + return true; + + free_pid: + free_ptr(pid_array); + free_ts: + free_ptr(ts_array); + free_cpu: + free_ptr(cpu_array); + free_offset: + free_ptr(offset_array); + + fprintf(stderr, "Failed to allocate memory during data loading.\n"); + return false; +} + +/** + * @brief Load the content of the trace data file into a table / matrix made + * of columns / arrays of data. The user is responsible for freeing the + * elements of the outputted array + * + * @param kshark_ctx: Input location for the session context pointer. + * @param offset_array: Output location for the array of record offsets. + * @param cpu_array: Output location for the array of CPU Ids. + * @param ts_array: Output location for the array of timestamps. + * @param pid_array: Output location for the array of Process Ids. + * @param event_array: Output location for the array of Event Ids. + * + * @returns The size of the outputted arrays in the case of success, or a + * negative error code on failure. + */ +size_t kshark_load_data_matrix(struct kshark_context *kshark_ctx, + uint64_t **offset_array, + uint16_t **cpu_array, + uint64_t **ts_array, + uint16_t **pid_array, + int **event_array) +{ + enum rec_type type = REC_ENTRY; + struct rec_list **rec_list; + ssize_t count, total = 0; + bool status; + int n_cpus; + + total = get_records(kshark_ctx, &rec_list, type); + if (total < 0) + goto fail; + + n_cpus = tracecmd_cpus(kshark_ctx->handle); + + status = data_matrix_alloc(total, offset_array, + cpu_array, + ts_array, + pid_array, + event_array); + if (!status) + goto fail_free; + + for (count = 0; count < total; count++) { + int next_cpu; + + next_cpu = pick_next_cpu(rec_list, n_cpus, type); + if (next_cpu >= 0) { + struct rec_list *rec = rec_list[next_cpu]; + struct kshark_entry *e = &rec->entry; + + if (offset_array) + (*offset_array)[count] = e->offset; + + if (cpu_array) + (*cpu_array)[count] = e->cpu; + + if (ts_array) + (*ts_array)[count] = e->ts; + + if (pid_array) + (*pid_array)[count] = e->pid; + + if (event_array) + (*event_array)[count] = e->event_id; + + rec_list[next_cpu] = rec_list[next_cpu]->next; + free(rec); + } + } + + /* There should be no entries left in rec_list. */ + free_rec_list(rec_list, n_cpus, type); + return total; + + fail_free: + free_rec_list(rec_list, n_cpus, type); + + fail: + fprintf(stderr, "Failed to allocate memory during data loading.\n"); + return -ENOMEM; +} + static const char *kshark_get_latency(struct tep_handle *pe, struct tep_record *record) { diff --git a/kernel-shark/src/libkshark.h b/kernel-shark/src/libkshark.h index c218b61c..fe353336 100644 --- a/kernel-shark/src/libkshark.h +++ b/kernel-shark/src/libkshark.h @@ -18,17 +18,16 @@ #include <errno.h> // Json-C -#include <json.h> +#include <json-c/json.h> #ifdef __cplusplus extern "C" { #endif // trace-cmd -#include "trace-cmd.h" -#include "trace-filter-hash.h" -#include "event-parse.h" -#include "trace-filter-hash.h" +#include "trace-cmd/trace-cmd.h" +#include "trace-cmd/trace-filter-hash.h" +#include "traceevent/event-parse.h" // KernelShark #include "libkshark-plugin.h" @@ -149,6 +148,13 @@ ssize_t kshark_load_data_entries(struct kshark_context *kshark_ctx, ssize_t kshark_load_data_records(struct kshark_context *kshark_ctx, struct tep_record ***data_rows); +size_t kshark_load_data_matrix(struct kshark_context *kshark_ctx, + uint64_t **offset_array, + uint16_t **cpu_array, + uint64_t **ts_array, + uint16_t **pid_array, + int **event_array); + ssize_t kshark_get_task_pids(struct kshark_context *kshark_ctx, int **pids); void kshark_close(struct kshark_context *kshark_ctx); |