diff options
| author | Yordan Karadzhov (VMware) <y.karadz@gmail.com> | 2019-07-09 18:56:47 +0300 |
|---|---|---|
| committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2019-07-09 21:34:21 -0400 |
| commit | adaba4d98daa45142cdd44aae56eda0011f136c3 (patch) | |
| tree | 0e1a8bf4b00d46e1fcf5c8054d0645cae13c4fc2 | |
| parent | 8d0c09ef1fe21277ad6c71d0603fd4a5c7e6c121 (diff) | |
| download | trace-cmd-adaba4d98daa45142cdd44aae56eda0011f136c3.tar.gz | |
kernel-shark: Remove a duplicate error message
If the capture process finishes with an error the _captureError() slot
will print an error message. We do not need to print identical message
in _captureFinished().
Link: http://lore.kernel.org/linux-trace-devel/20190709155650.2345-6-y.karadz@gmail.com
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
| -rw-r--r-- | kernel-shark/src/KsMainWindow.cpp | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 1e036320..752a17ae 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -1143,35 +1143,9 @@ void KsMainWindow::_captureStarted() _captureLocalServer.listen("KSCapture"); } -/** - * If the authorization could not be obtained because the user dismissed - * the authentication dialog (clicked Cancel), pkexec exits with a return - * value of 126. - */ -#define PKEXEC_DISMISS_RET 126 - void KsMainWindow::_captureFinished(int ret, QProcess::ExitStatus st) { - QProcess *capture = (QProcess *)sender(); - _captureLocalServer.close(); - - if (ret == PKEXEC_DISMISS_RET) { - /* - * Authorization could not be obtained because the user - * dismissed the authentication dialog. - */ - return; - } - - if (ret != 0 || st != QProcess::NormalExit) { - QString message = "Capture process failed:<br>"; - - message += capture->errorString(); - message += "<br>Try doing:<br> sudo make install"; - - _error(message, "captureFinishedErr", false, false); - } } void KsMainWindow::_captureError(QProcess::ProcessError error) |