aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Rostedt (VMware) <rostedt@goodmis.org>2019-07-10 09:40:00 -0400
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2019-07-18 17:03:48 -0400
commit8adfaa167000ab4e5c83cdc7e6f87861b766b93b (patch)
tree05d35157351666efa09b36d51b871e3ce647725a
parent644609a48f293b149823105def6089488d6eb1ea (diff)
downloadtrace-cmd-8adfaa167000ab4e5c83cdc7e6f87861b766b93b.tar.gz
kernel-shark: Show the standard error of kshark-record
When kshark-record fails, report the standard error which can be very useful for debugging the issue that when wrong. For example, after removing the kshark lib functions, instead of just having "Unknow error" print when kshark-record dialog fails, I now get: /usr/local/bin/kshark-record: error while loading shared libraries: libkshark-gui.so.0.9.8: cannot open shared object file: No such file or directory Link: http://lkml.kernel.org/r/20190710134725.436998774@goodmis.org Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-rw-r--r--kernel-shark/src/KsMainWindow.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 13b50795..54aa6d78 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -1179,7 +1179,7 @@ void KsMainWindow::_captureFinished(int ret, QProcess::ExitStatus st)
QString message = "Capture process failed:<br>";
message += capture->errorString();
-
+ message += capture->readAllStandardError();
_error(message, "captureFinishedErr", false, false);
}
}
@@ -1190,6 +1190,7 @@ void KsMainWindow::_captureError(QProcess::ProcessError error)
QString message = "Capture process failed:<br>";
message += capture->errorString();
+ message += capture->readAllStandardError();
_error(message, "captureFinishedErr", false, false);
}