diff options
| author | Jacob Keller <jacob.e.keller@intel.com> | 2014-02-13 14:28:19 -0800 |
|---|---|---|
| committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-02-14 15:21:48 +0200 |
| commit | 5c0229250b1f4c1e34405a508ee58ed91fffef35 (patch) | |
| tree | 4ac0d2abbffeb1b1791a92bcd2e0eea9af9381b7 | |
| parent | 6153f4f5a3410a4292766bd7dfcb9877eb5e81df (diff) | |
| download | aiaiai-5c0229250b1f4c1e34405a508ee58ed91fffef35.tar.gz | |
email-test-patchset: fix pcfg_reply_to_all
Through the course of several refactors, one of the patches
accidentallly broke reply_to_all functionality. In the older code, we
did a negative check, and if reply_to_all was not set, we would then
unset $to in order to prevent the compose_email function/code from
adding any Cc addresses.
However, one of the refactors missed this negative check, assumed it was
positive, and then changed the semantics so that reply_to_all = 0
caused reply behavior rather than otherwise.
This patch corrects the given commit by making it check for 1, instead
of not 1.
Artem: amend an weird comment while on it
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Fixes: 092f2ca246 "(email-test-patchset: further improve readability)"
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
| -rwxr-xr-x | email/aiaiai-email-test-patchset | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/email/aiaiai-email-test-patchset b/email/aiaiai-email-test-patchset index beb3e96..0028d3e 100755 --- a/email/aiaiai-email-test-patchset +++ b/email/aiaiai-email-test-patchset @@ -320,8 +320,8 @@ if [ -z "$pcfg_name" ]; then fi # Create the Cc list for replies that we'll be sending -if [ "$pcfg_reply_to_all" != "1" ]; then - # Replies all the patch recipients will be CCed +if [ "$pcfg_reply_to_all" = "1" ]; then + # All the patch recipients will be CCed reply_cc="$(merge_addresses "$to" "$cc")" reply_cc="$(merge_addresses "$reply_cc" "$pcfg_always_cc")" reply_cc=$(strip_address "$reply_cc" "$cfg_ownmail") |