aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVlastimil Babka <vbabka@suse.cz>2023-08-07 23:00:36 +0200
committerVlastimil Babka <vbabka@suse.cz>2024-04-19 11:53:54 +0200
commitf8e1610cbde4b323d77d8d284be4571b9a3b8c57 (patch)
tree52d9929dece0d69b42ada9a649af0b8a74866c4a
parentf8657a2aee72b67170591402e8f2f184d193274f (diff)
downloadlinux-b4/slub-percpu-caches.tar.gz
maple_tree: replace preallocation with slub percpu array prefillb4/slub-percpu-caches
With the percpu array we can try not doing the preallocations in maple tree, and instead make sure the percpu array is prefilled, and using GFP_ATOMIC in places that relied on the preallocation (in case we miss or fail trylock on the array), i.e. mas_store_prealloc(). For now simply add __GFP_NOFAIL there as well.
-rw-r--r--lib/maple_tree.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index b8979753c7110b..d1ff9f94484dfa 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5476,7 +5476,12 @@ void mas_store_prealloc(struct ma_state *mas, void *entry)
mas_wr_store_setup(&wr_mas);
trace_ma_write(__func__, mas, 0, entry);
+
+retry:
mas_wr_store_entry(&wr_mas);
+ if (unlikely(mas_nomem(mas, GFP_ATOMIC | __GFP_NOFAIL)))
+ goto retry;
+
MAS_WR_BUG_ON(&wr_mas, mas_is_err(mas));
mas_destroy(mas);
}
@@ -5495,8 +5500,6 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp)
MA_WR_STATE(wr_mas, mas, entry);
unsigned char node_size;
int request = 1;
- int ret;
-
if (unlikely(!mas->index && mas->last == ULONG_MAX))
goto ask_now;
@@ -5547,16 +5550,8 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp)
/* node store, slot store needs one node */
ask_now:
- mas_node_count_gfp(mas, request, gfp);
- if (likely(!mas_is_err(mas)))
- return 0;
+ return kmem_cache_prefill_percpu_array(maple_node_cache, request, gfp);
- mas_set_alloc_req(mas, 0);
- ret = xa_err(mas->node);
- mas_reset(mas);
- mas_destroy(mas);
- mas_reset(mas);
- return ret;
}
EXPORT_SYMBOL_GPL(mas_preallocate);