diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2023-11-13 20:49:39 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-11-13 20:50:12 -0800 |
| commit | 4b3812d90b2c93723adf4b6ce99240d301f7d5f9 (patch) | |
| tree | 44f7f5d260db4d8c056937894435c415322f75e9 | |
| parent | c0a2a1b0d631fc460d830f52d06211838874d655 (diff) | |
| download | linux-4b3812d90b2c93723adf4b6ce99240d301f7d5f9.tar.gz | |
Revert "ptp: Fixes a null pointer dereference in ptp_ioctl"
This reverts commit 8a4f030dbced6fc255cbe67b2d0a129947e18493.
Richard says:
The test itself is harmless, but keeping it will make people think,
"oh this pointer can be invalid."
In fact the core stack ensures that ioctl() can't be invoked after
release(), otherwise Bad Stuff happens.
Fixes: 8a4f030dbced ("ptp: Fixes a null pointer dereference in ptp_ioctl")
Link: https://lore.kernel.org/all/ZVAf_qdRfDAQYUt-@hoboy.vegasvil.org/
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/ptp/ptp_chardev.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c index e95a6ed130ef44..3f7a7478880240 100644 --- a/drivers/ptp/ptp_chardev.c +++ b/drivers/ptp/ptp_chardev.c @@ -176,8 +176,6 @@ long ptp_ioctl(struct posix_clock_context *pccontext, unsigned int cmd, int enable, err = 0; tsevq = pccontext->private_clkdata; - if (!tsevq) - return -EINVAL; switch (cmd) { |