diff options
| author | Wang Yufen <wangyufen@huawei.com> | 2022-09-23 15:02:37 +0800 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2022-09-27 11:00:02 +0200 |
| commit | bc7a319844891746135dc1f34ab9df78d636a3ac (patch) | |
| tree | 83d238648eb98980f1104e9b8f3f81c78e74a708 | |
| parent | ea64cdfad124922c931633e39287c5a31a9b14a1 (diff) | |
| download | linux-trace-bc7a319844891746135dc1f34ab9df78d636a3ac.tar.gz | |
selftests: Fix the if conditions of in test_extra_filter()
The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So
if bind success or errno != EADDRINUSE, testcase should be failed.
Fixes: 3ca8e4029969 ("soreuseport: BPF selection functional test")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Link: https://lore.kernel.org/r/1663916557-10730-1-git-send-email-wangyufen@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | tools/testing/selftests/net/reuseport_bpf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/reuseport_bpf.c b/tools/testing/selftests/net/reuseport_bpf.c index 072d709c96b48..65aea27d761ca 100644 --- a/tools/testing/selftests/net/reuseport_bpf.c +++ b/tools/testing/selftests/net/reuseport_bpf.c @@ -328,7 +328,7 @@ static void test_extra_filter(const struct test_params p) if (bind(fd1, addr, sockaddr_size())) error(1, errno, "failed to bind recv socket 1"); - if (!bind(fd2, addr, sockaddr_size()) && errno != EADDRINUSE) + if (!bind(fd2, addr, sockaddr_size()) || errno != EADDRINUSE) error(1, errno, "bind socket 2 should fail with EADDRINUSE"); free(addr); |