diff options
| author | Nathan Lynch <nathanl@linux.ibm.com> | 2024-04-04 17:02:09 -0500 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2024-04-12 14:40:07 +1000 |
| commit | 210cfef579260ed6c3b700e7baeae51a5e183f43 (patch) | |
| tree | 90ab3030631136e27e7f43b8bb9ff30bc0b792de /tools | |
| parent | 69630926011c1f7170a465b7b5c228deb66e9372 (diff) | |
| download | linux-210cfef579260ed6c3b700e7baeae51a5e183f43.tar.gz | |
selftests/powerpc/papr-vpd: Fix missing variable initialization
The "close handle without consuming VPD" testcase has inconsistent
results because it fails to initialize the location code object it
passes to ioctl() to create a VPD handle. Initialize the location code
to the empty string as intended.
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Fixes: 9118c5d32bdd ("powerpc/selftests: Add test for papr-vpd")
Reported-by: Geetika Moolchandani <geetika@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240404-papr-vpd-test-uninit-lc-v2-1-37bff46c65a5@linux.ibm.com
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c index 505294da1b9fb5..d6f99eb9be659d 100644 --- a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c +++ b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c @@ -154,7 +154,7 @@ static int dev_papr_vpd_null_handle(void) static int papr_vpd_close_handle_without_reading(void) { const int devfd = open(DEVPATH, O_RDONLY); - struct papr_location_code lc; + struct papr_location_code lc = { .str = "", }; int fd; SKIP_IF_MSG(devfd < 0 && errno == ENOENT, |