diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2006-01-31 17:51:44 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2006-01-31 17:51:44 -0800 |
| commit | 78b910429e2c037533d2a7bd9e95b4f94f905ef8 (patch) | |
| tree | 39d48ffb6b297ceae30a577f198b3de785785a68 /net | |
| parent | f9d9516db71eb3a8547948cdddc139eb1c1b9aee (diff) | |
| download | linux-78b910429e2c037533d2a7bd9e95b4f94f905ef8.tar.gz | |
[IPV6] tcp_v6_send_synack: release the destination
This patch fix dst reference counting in tcp_v6_send_synack
Analysis:
Currently tcp_v6_send_synack is never called with a dst entry
so dst always comes in as NULL.
ip6_dst_lookup calls ip6_route_output which calls dst_hold
before it returns the dst entry. Neither xfrm_lookup
nor tcp_make_synack consume the dst entry so we still have
a dst_entry with a bumped refrence count at the end of
this function.
Therefore we need to call dst_release just before we return
just like tcp_v4_send_synack does.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/tcp_ipv6.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 66d04004afdaec..ca9cf6853755fc 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -515,6 +515,7 @@ static int tcp_v6_send_synack(struct sock *sk, struct request_sock *req, done: if (opt && opt != np->opt) sock_kfree_s(sk, opt, opt->tot_len); + dst_release(dst); return err; } |