diff options
| author | Florian Westphal <fw@strlen.de> | 2023-04-13 17:13:19 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2023-04-22 01:39:40 +0200 |
| commit | 9a32e9850686599ed194ccdceb6cd3dd56b2d9b9 (patch) | |
| tree | 0e183ca0e7bb58bd842d56ba9b1aeaa5c785cc75 /net/netfilter/nfnetlink.c | |
| parent | 63e9bbbcca60333490e13744ae736d8f988e4950 (diff) | |
| download | linux-9a32e9850686599ed194ccdceb6cd3dd56b2d9b9.tar.gz | |
netfilter: nf_tables: don't write table validation state without mutex
The ->cleanup callback needs to be removed, this doesn't work anymore as
the transaction mutex is already released in the ->abort function.
Just do it after a successful validation pass, this either happens
from commit or abort phases where transaction mutex is held.
Fixes: f102d66b335a ("netfilter: nf_tables: use dedicated mutex to guard transactions")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/nfnetlink.c')
| -rw-r--r-- | net/netfilter/nfnetlink.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index 81c7737c803a6e..ae7146475d17a2 100644 --- a/net/netfilter/nfnetlink.c +++ b/net/netfilter/nfnetlink.c @@ -590,8 +590,6 @@ done: goto replay_abort; } } - if (ss->cleanup) - ss->cleanup(net); nfnl_err_deliver(&err_list, oskb); kfree_skb(skb); |