diff options
| author | Yick Xie <yick.xie@gmail.com> | 2024-04-19 01:06:10 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-04-19 20:10:15 -0700 |
| commit | 680d11f6e5427b6af1321932286722d24a8b16c1 (patch) | |
| tree | 63f411c69f87ef289274a426991b64ca3ce1af52 /net/ipv4 | |
| parent | f58f45c1e5b92975e91754f5407250085a6ae7cf (diff) | |
| download | linux-680d11f6e5427b6af1321932286722d24a8b16c1.tar.gz | |
udp: preserve the connected status if only UDP cmsg
If "udp_cmsg_send()" returned 0 (i.e. only UDP cmsg),
"connected" should not be set to 0. Otherwise it stops
the connected socket from using the cached route.
Fixes: 2e8de8576343 ("udp: add gso segment cmsg")
Signed-off-by: Yick Xie <yick.xie@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20240418170610.867084-1-yick.xie@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/udp.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index c02bf011d4a6f4..420905be5f30c9 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1123,16 +1123,17 @@ int udp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) if (msg->msg_controllen) { err = udp_cmsg_send(sk, msg, &ipc.gso_size); - if (err > 0) + if (err > 0) { err = ip_cmsg_send(sk, msg, &ipc, sk->sk_family == AF_INET6); + connected = 0; + } if (unlikely(err < 0)) { kfree(ipc.opt); return err; } if (ipc.opt) free = 1; - connected = 0; } if (!ipc.opt) { struct ip_options_rcu *inet_opt; |