diff options
| author | Eric Dumazet <edumazet@google.com> | 2022-01-05 09:08:49 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-01-05 09:50:06 -0800 |
| commit | 2d6ec25539b0e7a4b4ad670abbcb3ec27b33e8ce (patch) | |
| tree | 97999968629946b6d0bfa7c4910663eb0d6fcd95 /net/ethtool | |
| parent | 88248c357c2a8dbff899770dc02e2edf89d989aa (diff) | |
| download | linux-2d6ec25539b0e7a4b4ad670abbcb3ec27b33e8ce.tar.gz | |
netlink: do not allocate a device refcount tracker in ethnl_default_notify()
As reported by Johannes, the tracker allocated in
ethnl_default_notify() is not really needed, as this
function is not expected to change a device reference count.
Fixes: e4b8954074f6 ("netlink: add net device refcount tracker to struct ethnl_req_info")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Tested-by: Johannes Berg <johannes@sipsolutions.net>
Link: https://lore.kernel.org/r/20220105170849.2610470-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ethtool')
| -rw-r--r-- | net/ethtool/netlink.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c index ea23659fab28c..5fe8f4ae2cebc 100644 --- a/net/ethtool/netlink.c +++ b/net/ethtool/netlink.c @@ -627,7 +627,6 @@ static void ethnl_default_notify(struct net_device *dev, unsigned int cmd, } req_info->dev = dev; - netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL); req_info->flags |= ETHTOOL_FLAG_COMPACT_BITSETS; ethnl_init_reply_data(reply_data, ops, dev); |