diff options
| author | David Gow <davidgow@google.com> | 2024-02-21 17:27:16 +0800 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2024-02-27 15:26:02 -0700 |
| commit | 0a549ed22c3c7cc6da5c5f5918efd019944489a5 (patch) | |
| tree | bf675eb03f865bd0435433ac0ae3fbc3fa206a63 /lib | |
| parent | d2733a026fc7247ba42d7a8e1b737cf14bf1df21 (diff) | |
| download | linux-0a549ed22c3c7cc6da5c5f5918efd019944489a5.tar.gz | |
lib: memcpy_kunit: Fix an invalid format specifier in an assertion msg
The 'i' passed as an assertion message is a size_t, so should use '%zu',
not '%d'.
This was found by annotating the _MSG() variants of KUnit's assertions
to let gcc validate the format strings.
Fixes: bb95ebbe89a7 ("lib: Introduce CONFIG_MEMCPY_KUNIT_TEST")
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/memcpy_kunit.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/memcpy_kunit.c b/lib/memcpy_kunit.c index 440aee705cccab..30e00ef0bf2e0f 100644 --- a/lib/memcpy_kunit.c +++ b/lib/memcpy_kunit.c @@ -32,7 +32,7 @@ struct some_bytes { BUILD_BUG_ON(sizeof(instance.data) != 32); \ for (size_t i = 0; i < sizeof(instance.data); i++) { \ KUNIT_ASSERT_EQ_MSG(test, instance.data[i], v, \ - "line %d: '%s' not initialized to 0x%02x @ %d (saw 0x%02x)\n", \ + "line %d: '%s' not initialized to 0x%02x @ %zu (saw 0x%02x)\n", \ __LINE__, #instance, v, i, instance.data[i]); \ } \ } while (0) @@ -41,7 +41,7 @@ struct some_bytes { BUILD_BUG_ON(sizeof(one) != sizeof(two)); \ for (size_t i = 0; i < sizeof(one); i++) { \ KUNIT_EXPECT_EQ_MSG(test, one.data[i], two.data[i], \ - "line %d: %s.data[%d] (0x%02x) != %s.data[%d] (0x%02x)\n", \ + "line %d: %s.data[%zu] (0x%02x) != %s.data[%zu] (0x%02x)\n", \ __LINE__, #one, i, one.data[i], #two, i, two.data[i]); \ } \ kunit_info(test, "ok: " TEST_OP "() " name "\n"); \ |