diff options
| author | Jens Axboe <axboe@kernel.dk> | 2023-12-21 08:49:18 -0700 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-12-21 08:49:18 -0700 |
| commit | 0a535eddbe0dc1de4386046ab849f08aeb2f8faf (patch) | |
| tree | c15ad68745ed65233477ea63047a778727ff54a0 /io_uring | |
| parent | 6e5e6d274956305f1fc0340522b38f5f5be74bdb (diff) | |
| download | linux-0a535eddbe0dc1de4386046ab849f08aeb2f8faf.tar.gz | |
io_uring/rw: ensure io->bytes_done is always initialized
If IOSQE_ASYNC is set and we fail importing an iovec for a readv or
writev request, then we leave ->bytes_done uninitialized and hence the
eventual failure CQE posted can potentially have a random res value
rather than the expected -EINVAL.
Setup ->bytes_done before potentially failing, so we have a consistent
value if we fail the request early.
Cc: stable@vger.kernel.org
Reported-by: xingwei lee <xrivendell7@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring')
| -rw-r--r-- | io_uring/rw.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/io_uring/rw.c b/io_uring/rw.c index 4943d683508b4d..0c856726b15db3 100644 --- a/io_uring/rw.c +++ b/io_uring/rw.c @@ -589,15 +589,19 @@ static inline int io_rw_prep_async(struct io_kiocb *req, int rw) struct iovec *iov; int ret; + iorw->bytes_done = 0; + iorw->free_iovec = NULL; + /* submission path, ->uring_lock should already be taken */ ret = io_import_iovec(rw, req, &iov, &iorw->s, 0); if (unlikely(ret < 0)) return ret; - iorw->bytes_done = 0; - iorw->free_iovec = iov; - if (iov) + if (iov) { + iorw->free_iovec = iov; req->flags |= REQ_F_NEED_CLEANUP; + } + return 0; } |