diff options
| author | Eric Dumazet <edumazet@google.com> | 2023-06-06 07:41:15 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-06-07 10:08:45 +0100 |
| commit | 5c3b74a92aa285a3df722bf6329ba7ccf70346d6 (patch) | |
| tree | a5898632fd2ce3dd1f7dfca691a0a1f6dfdf1231 /include/linux/netdevice.h | |
| parent | 1e5c647c3f6d4f8497dedcd226204e1880e0ffb3 (diff) | |
| download | linux-5c3b74a92aa285a3df722bf6329ba7ccf70346d6.tar.gz | |
rfs: annotate lockless accesses to RFS sock flow table
Add READ_ONCE()/WRITE_ONCE() on accesses to the sock flow table.
This also prevents a (smart ?) compiler to remove the condition in:
if (table->ents[index] != newval)
table->ents[index] = newval;
We need the condition to avoid dirtying a shared cache line.
Fixes: fec5e652e58f ("rfs: Receive Flow Steering")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/netdevice.h')
| -rw-r--r-- | include/linux/netdevice.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 08fbd4622ccf73..e6f22b7403d014 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -768,8 +768,11 @@ static inline void rps_record_sock_flow(struct rps_sock_flow_table *table, /* We only give a hint, preemption can change CPU under us */ val |= raw_smp_processor_id(); - if (table->ents[index] != val) - table->ents[index] = val; + /* The following WRITE_ONCE() is paired with the READ_ONCE() + * here, and another one in get_rps_cpu(). + */ + if (READ_ONCE(table->ents[index]) != val) + WRITE_ONCE(table->ents[index], val); } } |