diff options
| author | Boris Burkov <boris@bur.io> | 2024-03-26 12:01:28 -0700 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-04-02 19:19:13 +0200 |
| commit | 6e68de0bb0ed59e0554a0c15ede7308c47351e2d (patch) | |
| tree | 797903b9feb8622d1fa013811ef4ce9d09444826 /fs | |
| parent | 3c6f0c5ecc8910d4ffb0dfe85609ebc0c91c8f34 (diff) | |
| download | linux-6e68de0bb0ed59e0554a0c15ede7308c47351e2d.tar.gz | |
btrfs: always clear PERTRANS metadata during commit
It is possible to clear a root's IN_TRANS tag from the radix tree, but
not clear its PERTRANS, if there is some error in between. Eliminate
that possibility by moving the free up to where we clear the tag.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/transaction.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 1f10082d35d928..85f359e0e0a7f2 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -1494,6 +1494,7 @@ static noinline int commit_fs_roots(struct btrfs_trans_handle *trans) radix_tree_tag_clear(&fs_info->fs_roots_radix, (unsigned long)root->root_key.objectid, BTRFS_ROOT_TRANS_TAG); + btrfs_qgroup_free_meta_all_pertrans(root); spin_unlock(&fs_info->fs_roots_radix_lock); btrfs_free_log(trans, root); @@ -1518,7 +1519,6 @@ static noinline int commit_fs_roots(struct btrfs_trans_handle *trans) if (ret2) return ret2; spin_lock(&fs_info->fs_roots_radix_lock); - btrfs_qgroup_free_meta_all_pertrans(root); } } spin_unlock(&fs_info->fs_roots_radix_lock); |