diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-04-01 14:00:00 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-05-10 14:06:00 -0700 |
| commit | 48f2c681df4329b50fc92516c10e0398ca127242 (patch) | |
| tree | ced9ddc5ff900b7e2722389571d333f117deb379 /fs/pstore | |
| parent | ac9a78681b921877518763ba0e89202254349d1b (diff) | |
| download | linux-48f2c681df4329b50fc92516c10e0398ca127242.tar.gz | |
pstore/ram: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230401120000.2487153-1-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'fs/pstore')
| -rw-r--r-- | fs/pstore/ram.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index ade66dbe5f396..2f625e1fa8d8e 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -875,7 +875,7 @@ fail_out: return err; } -static int ramoops_remove(struct platform_device *pdev) +static void ramoops_remove(struct platform_device *pdev) { struct ramoops_context *cxt = &oops_cxt; @@ -885,8 +885,6 @@ static int ramoops_remove(struct platform_device *pdev) cxt->pstore.bufsize = 0; ramoops_free_przs(cxt); - - return 0; } static const struct of_device_id dt_match[] = { @@ -896,7 +894,7 @@ static const struct of_device_id dt_match[] = { static struct platform_driver ramoops_driver = { .probe = ramoops_probe, - .remove = ramoops_remove, + .remove_new = ramoops_remove, .driver = { .name = "ramoops", .of_match_table = dt_match, |