aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/ti_usb_3410_5052.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2021-04-12 11:38:14 +0200
committerJohan Hovold <johan@kernel.org>2021-04-13 18:19:33 +0200
commitc505b8b2ef274ce60a79f18a33bf23efd17a04de (patch)
treecac29ce2bdf4f21e125b1363d4fdfb5cbc4b3745 /drivers/usb/serial/ti_usb_3410_5052.c
parent4b8e07951ff53e702bd5d6d21450b17152d124d7 (diff)
downloadlinux-c505b8b2ef274ce60a79f18a33bf23efd17a04de.tar.gz
USB: serial: ti_usb_3410_5052: reduce drain delay to one char
The three-character drain delay was added by commit f1175daa5312 ("USB: ti_usb_3410_5052: kill custom closing_wait") when removing the custom closing-wait implementation, which used a fixed 20 ms poll period and drain delay. This was likely a bit too conservative as a one-character timeout (e.g. 33 ms at 300 bps) should be enough to compensate for the lack of a transmitter empty bit in the TUSB5052 line-status register. Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/ti_usb_3410_5052.c')
-rw-r--r--drivers/usb/serial/ti_usb_3410_5052.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index 03839289d6c09..8ed64115987f7 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -610,7 +610,11 @@ static int ti_port_probe(struct usb_serial_port *port)
usb_set_serial_port_data(port, tport);
- port->port.drain_delay = 3;
+ /*
+ * The TUSB5052 LSR does not tell when the transmitter shift register
+ * has emptied so add a one-character drain delay.
+ */
+ port->port.drain_delay = 1;
return 0;
}