diff options
| author | Nathan Chancellor <nathan@kernel.org> | 2021-06-21 11:56:45 -0700 |
|---|---|---|
| committer | Jassi Brar <jaswinder.singh@linaro.org> | 2021-06-26 12:06:18 -0500 |
| commit | e80a7e7eafcd5e75bf8c73164cae954b3f0addbc (patch) | |
| tree | 7d230f6ec62b6f0d0c7cb6f183fcc918f800e5f4 /drivers/mailbox | |
| parent | 8a7cdb108d3020e221944fbd52b9e047f3f51594 (diff) | |
| download | linux-e80a7e7eafcd5e75bf8c73164cae954b3f0addbc.tar.gz | |
mailbox: imx: Avoid using val uninitialized in imx_mu_isr()
Clang warns:
drivers/mailbox/imx-mailbox.c:284:2: warning: variable 'val' is used
uninitialized whenever switch default is taken
[-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/mailbox/imx-mailbox.c:288:7: note: uninitialized use occurs here
if (!val)
^~~
drivers/mailbox/imx-mailbox.c:263:9: note: initialize the variable 'val'
to silence this warning
u32 val, ctrl;
^
= 0
1 warning generated.
Prior to commit 91c8c1fbe498 ("mailbox: imx: add xSR/xCR register
array"), val was always initialized in imx_mu_isr() but now, it is not
initialized in the default case. Return IRQ_NONE like the statement
below does and add a message that there is an unhandled type for this
switch statement so that it can be updated.
Fixes: 91c8c1fbe498 ("mailbox: imx: add xSR/xCR register array")
Link: https://github.com/ClangBuiltLinux/linux/issues/1404
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Diffstat (limited to 'drivers/mailbox')
| -rw-r--r-- | drivers/mailbox/imx-mailbox.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index bc51bd3c19997..0ce75c6b36b65 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -282,7 +282,9 @@ static irqreturn_t imx_mu_isr(int irq, void *p) (ctrl & IMX_MU_xCR_GIEn(priv->dcfg->type, cp->idx)); break; default: - break; + dev_warn_ratelimited(priv->dev, "Unhandled channel type %d\n", + cp->type); + return IRQ_NONE; } if (!val) |