diff options
| author | Nathan Chancellor <nathan@kernel.org> | 2023-02-15 10:12:12 -0700 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2023-02-16 10:16:31 +1100 |
| commit | 748ea32d2dbd813d3bd958117bde5191182f909a (patch) | |
| tree | 6bedd59a809ee51fd49552978507c5ebec7cac6d /drivers/macintosh/windfarm_lm75_sensor.c | |
| parent | b0ae5b6f3c298a005b73556740526c0e24a5633c (diff) | |
| download | linux-748ea32d2dbd813d3bd958117bde5191182f909a.tar.gz | |
macintosh: windfarm: Use unsigned type for 1-bit bitfields
Clang warns:
drivers/macintosh/windfarm_lm75_sensor.c:63:14: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
lm->inited = 1;
^ ~
drivers/macintosh/windfarm_smu_sensors.c:356:19: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
pow->fake_volts = 1;
^ ~
drivers/macintosh/windfarm_smu_sensors.c:368:18: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
pow->quadratic = 1;
^ ~
There is no bug here since no code checks the actual value of these
fields, just whether or not they are zero (boolean context), but this
can be easily fixed by switching to an unsigned type.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230215-windfarm-wsingle-bit-bitfield-constant-conversion-v1-1-26415072e855@kernel.org
Diffstat (limited to 'drivers/macintosh/windfarm_lm75_sensor.c')
| -rw-r--r-- | drivers/macintosh/windfarm_lm75_sensor.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/macintosh/windfarm_lm75_sensor.c b/drivers/macintosh/windfarm_lm75_sensor.c index 24f0a444d3122c..9c6febce2376ba 100644 --- a/drivers/macintosh/windfarm_lm75_sensor.c +++ b/drivers/macintosh/windfarm_lm75_sensor.c @@ -33,8 +33,8 @@ #endif struct wf_lm75_sensor { - int ds1775 : 1; - int inited : 1; + unsigned int ds1775 : 1; + unsigned int inited : 1; struct i2c_client *i2c; struct wf_sensor sens; }; |