aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ide/pci/piix.c
diff options
context:
space:
mode:
authorJayachandran C <c.jayachandran@gmail.com>2006-02-03 03:04:51 -0800
committerLinus Torvalds <torvalds@g5.osdl.org>2006-02-03 08:32:11 -0800
commit12fc1d7b4b08a80776de3073439a09f54ce31f8f (patch)
treed98b6605704016950afab7cf60c60cafc78e5b60 /drivers/ide/pci/piix.c
parentdb9a369ec172c8251dbc6f7bf6bf13f6c5b6e7f5 (diff)
downloadlinux-12fc1d7b4b08a80776de3073439a09f54ce31f8f.tar.gz
[PATCH] IPMI: fix issues reported by Coverity in ipmi_msghandler.c
While looking to the report by Coverity in ipmi, I came across the following issue: The IPMI message handler relies on two defines which are the same -one in include/linux/ipmi.h #define IPMI_NUM_CHANNELS 0x10 and one in drivers/char/ipmi/ipmi_msghandler. #define IPMI_MAX_CHANNELS 16 These are used interchangeably in ipmi_msghandler.c, but since the array addr->channels[] is of size IPMI_MAX_CHANNELS, I have made a patch that uses IPMI_MAX_CHANNELS for all the checks for the array index. NOTE: You could probably remove the line that defines IPMI_NUM_CHANNELS from ipmi.h, or move IPMI_MAX_CHANNELS to ipmi.h Signed-off-by: Jayachandran C. <c.jayachandran@gmail.com> Cc: Corey Minyard <minyard@acm.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/ide/pci/piix.c')
0 files changed, 0 insertions, 0 deletions