diff options
| author | Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2023-08-24 16:28:24 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2023-08-25 06:19:29 -0700 |
| commit | 1e3c3a7989495512f2b180adb4f22d500cb79960 (patch) | |
| tree | 0aa6b852e86ac066a13434c74916238b638dfc01 /drivers/hwmon | |
| parent | 70332ec735202ceb874407be29f68919ab898dce (diff) | |
| download | linux-1e3c3a7989495512f2b180adb4f22d500cb79960.tar.gz | |
hwmon: (vt8231) Do PCI error checks on own line
Instead of if conditions with line splits, use the usual error handling
pattern with a separate variable to improve readability.
No functional changes intended.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230824132832.78705-7-ilpo.jarvinen@linux.intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/vt8231.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c index b7c6392ba67374..16bc16d33cd1d5 100644 --- a/drivers/hwmon/vt8231.c +++ b/drivers/hwmon/vt8231.c @@ -971,13 +971,15 @@ static int vt8231_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) { u16 address, val; + int ret; + if (force_addr) { address = force_addr & 0xff00; dev_warn(&dev->dev, "Forcing ISA address 0x%x\n", address); - if (PCIBIOS_SUCCESSFUL != - pci_write_config_word(dev, VT8231_BASE_REG, address | 1)) + ret = pci_write_config_word(dev, VT8231_BASE_REG, address | 1); + if (ret != PCIBIOS_SUCCESSFUL) return -ENODEV; } @@ -997,9 +999,8 @@ static int vt8231_pci_probe(struct pci_dev *dev, if (!(val & 0x0001)) { dev_warn(&dev->dev, "enabling sensors\n"); - if (PCIBIOS_SUCCESSFUL != - pci_write_config_word(dev, VT8231_ENABLE_REG, - val | 0x0001)) + ret = pci_write_config_word(dev, VT8231_ENABLE_REG, val | 0x1); + if (ret != PCIBIOS_SUCCESSFUL) return -ENODEV; } |