aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorSamasth Norway Ananda <samasth.norway.ananda@oracle.com>2024-01-25 13:19:33 -0800
committerConor Dooley <conor.dooley@microchip.com>2024-01-29 18:52:11 +0000
commit0abcac4fe3ca3aeaef40ad53c0b295b2d5f8cbf1 (patch)
tree7678943943b3f2b8889a9ec2d66ed547f114285d /drivers/firmware
parent6613476e225e090cc9aad49be7fa504e290dd33d (diff)
downloadlinux-0abcac4fe3ca3aeaef40ad53c0b295b2d5f8cbf1.tar.gz
firmware: microchip: fix wrong sizeof argument
response_msg is a pointer to an unsigned int (u32). So passing just response_msg to sizeof would not print the size of the variable. To get the size of response_msg we need to pass it as a pointer variable. Fixes: ec5b0f1193ad ("firmware: microchip: add PolarFire SoC Auto Update support") Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/microchip/mpfs-auto-update.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/microchip/mpfs-auto-update.c b/drivers/firmware/microchip/mpfs-auto-update.c
index 81f5f62e34fce0..682e417be5a3e4 100644
--- a/drivers/firmware/microchip/mpfs-auto-update.c
+++ b/drivers/firmware/microchip/mpfs-auto-update.c
@@ -167,7 +167,7 @@ static int mpfs_auto_update_verify_image(struct fw_upload *fw_uploader)
u32 *response_msg;
int ret;
- response_msg = devm_kzalloc(priv->dev, AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(response_msg),
+ response_msg = devm_kzalloc(priv->dev, AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg),
GFP_KERNEL);
if (!response_msg)
return -ENOMEM;