diff options
| author | Hannes Reinecke <hare@suse.de> | 2023-07-31 16:34:13 +0200 |
|---|---|---|
| committer | Damien Le Moal <dlemoal@kernel.org> | 2023-08-02 17:45:13 +0900 |
| commit | 43aa43351bb551a7732c1b9f6e8ebb9a6f30b063 (patch) | |
| tree | b3fab7ced42137e5314c2439c72ab53d0ad9abf5 /drivers/ata | |
| parent | ff8072d589dcff7c1f0345a6ec98b5fc1e9ee2a1 (diff) | |
| download | linux-43aa43351bb551a7732c1b9f6e8ebb9a6f30b063.tar.gz | |
ata,scsi: remove ata_sas_port_{start,stop} callbacks
Callbacks are empty now, so remove them.
Also, remove the call to ap->ops->port_start() in ata_sas_port_init(),
as this would otherwise cause a NULL pointer dereference, now when the
callback is gone.
Signed-off-by: Hannes Reinecke <hare@suse.de>
[niklas: remove the call to ap->ops->port_start() in ata_sas_port_init()]
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-sata.c | 38 |
1 files changed, 0 insertions, 38 deletions
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index cf401a54c9e16c..ce392b5b5930f9 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -1145,40 +1145,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host, EXPORT_SYMBOL_GPL(ata_sas_port_alloc); /** - * ata_sas_port_start - Set port up for dma. - * @ap: Port to initialize - * - * Called just after data structures for each port are - * initialized. - * - * May be used as the port_start() entry in ata_port_operations. - * - * LOCKING: - * Inherited from caller. - */ -int ata_sas_port_start(struct ata_port *ap) -{ - /* the port is marked as frozen at allocation time */ - return 0; -} -EXPORT_SYMBOL_GPL(ata_sas_port_start); - -/** - * ata_sas_port_stop - Undo ata_sas_port_start() - * @ap: Port to shut down - * - * May be used as the port_stop() entry in ata_port_operations. - * - * LOCKING: - * Inherited from caller. - */ - -void ata_sas_port_stop(struct ata_port *ap) -{ -} -EXPORT_SYMBOL_GPL(ata_sas_port_stop); - -/** * ata_sas_async_probe - simply schedule probing and return * @ap: Port to probe * @@ -1211,10 +1177,6 @@ EXPORT_SYMBOL_GPL(ata_sas_sync_probe); int ata_sas_port_init(struct ata_port *ap) { - int rc = ap->ops->port_start(ap); - - if (rc) - return rc; ap->print_id = atomic_inc_return(&ata_print_id); return 0; } |