diff options
| author | Minjie Du <duminjie@vivo.com> | 2023-07-25 11:06:25 +0800 |
|---|---|---|
| committer | Damien Le Moal <dlemoal@kernel.org> | 2023-07-26 08:20:22 +0900 |
| commit | 4139f992c49356391fb086c0c8ce51f66c26d623 (patch) | |
| tree | 1fcfd50e44f5eb1bd6e7835a5bc867ff0a91e5e8 /drivers/ata | |
| parent | cec148c2476a6e06cf8190b20de81f98983b53ca (diff) | |
| download | linux-4139f992c49356391fb086c0c8ce51f66c26d623.tar.gz | |
ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
It is possible for dma_request_chan() to return EPROBE_DEFER, which
means acdev->host->dev is not ready yet. At this point dev_err() will
have no output. Use dev_err_probe() instead.
Signed-off-by: Minjie Du <duminjie@vivo.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/pata_arasan_cf.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c index 6ab294322e792..314eaa1679540 100644 --- a/drivers/ata/pata_arasan_cf.c +++ b/drivers/ata/pata_arasan_cf.c @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work) /* dma_request_channel may sleep, so calling from process context */ acdev->dma_chan = dma_request_chan(acdev->host->dev, "data"); if (IS_ERR(acdev->dma_chan)) { - dev_err(acdev->host->dev, "Unable to get dma_chan\n"); + dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan), + "Unable to get dma_chan\n"); acdev->dma_chan = NULL; goto chan_request_fail; } |