diff options
| author | Steve French <stfrench@microsoft.com> | 2024-04-06 23:16:08 -0500 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2024-04-11 16:02:02 -0500 |
| commit | 28e0947651ce6a2200b9a7eceb93282e97d7e51a (patch) | |
| tree | 4431f896b80d8f2eca5695574f680b4d0cd6989f | |
| parent | ec4535b2a1d709d3a1fbec26739c672f13c98a7b (diff) | |
| download | linux-28e0947651ce6a2200b9a7eceb93282e97d7e51a.tar.gz | |
smb3: fix Open files on server counter going negative
We were decrementing the count of open files on server twice
for the case where we were closing cached directories.
Fixes: 8e843bf38f7b ("cifs: return a single-use cfid if we did not get a lease")
Cc: stable@vger.kernel.org
Acked-by: Bharath SM <bharathsm@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/client/cached_dir.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c index 13a9d7acf8f8ec..0ff2491c311d8a 100644 --- a/fs/smb/client/cached_dir.c +++ b/fs/smb/client/cached_dir.c @@ -433,8 +433,8 @@ smb2_close_cached_fid(struct kref *ref) if (cfid->is_open) { rc = SMB2_close(0, cfid->tcon, cfid->fid.persistent_fid, cfid->fid.volatile_fid); - if (rc != -EBUSY && rc != -EAGAIN) - atomic_dec(&cfid->tcon->num_remote_opens); + if (rc) /* should we retry on -EBUSY or -EAGAIN? */ + cifs_dbg(VFS, "close cached dir rc %d\n", rc); } free_cached_dir(cfid); |