aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2023-06-20remail: v0.14HEADv0.14testingmasterThomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Make From header mangling less convolutedThomas Gleixner1-11/+44
Due to the requirement to reencrypt the incoming mail, remail must rewrite the mail headers and create a new email with the 'From:' header being the list address. So remail implemented a scheme to mangle the original senders name into the reencrypted mails 'From:' header. That fell flat on its nose when there was an incoming mail which had no name part and just consisted of the actual email address. Instead of differentiating between these cases the authors sleep deprived and grump laden brain decided to implement 'From:' mangling in the way it is now. It converts the original sender mail address '[Name] <mailname@sender.domain>' to: 'list-name for mailname_at_sender.domain' <list-name@list.domain> This is hard to read and follow. Use the common format: 'Name via list-name' <list-name@list.domain> Except for the case where the original 'From:' header is a plain email address without a name. This will mangle it to: 'mailname at sender.domain via list-name' <list-name@list.domain> The 'via list-name' add on is technically not required but is useful to visually differentiate the name in auto-completion. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Add X-Original-From headerThomas Gleixner2-6/+21
The 'From:' header mangling makes it unnecessarily hard to figure out the name and email address of the person who posted to a list. Save the original sender in the 'X-Original-From:' header. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Suggested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://wiki.ietf.org/group/dmarc/XOriginalFrom
2023-06-20remail: Fix closing boundariesThomas Gleixner1-1/+2
EmailMessage.defects reports a CloseBoundaryNotFoundDefect on the outgoing PGP message. Add the missing closing boundary after the PGP payload section and fix up the closing boundaries format in msg_strip_.*(). Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Check outgoing mails for defectsThomas Gleixner2-3/+8
EmailMessage.defects allows to inspect outgoing mails for defects. If found report them in logging. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Simplify send_mail()Thomas Gleixner1-68/+37
1) Use EmailMessage EmailMessage with the default policy handles header encoding correctly by default and uses '\n' line separators, which works for both as_string() and smtplib.send_message() correctly. The latter flattens the message with the RFC conform '\r\n' line separators unconditionally. Aside of that EmailMessage provides defects reporting which is useful to ensure that the outgoing mails are correct. A check for that will be added later 2) Simplify header handling Remove all existing headers from the cloned message first and add those which are required either as new headers or copied from the original message which was handed in to send_mail() Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Unify send_mail()Thomas Gleixner1-15/+8
No need for two functions. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Simplify msg_set_header()Thomas Gleixner1-6/+4
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Use email.utils.get_addresses()Thomas Gleixner2-37/+4
Replace more historical homebrewn parsing Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Use email.utils.parseaddr()Thomas Gleixner1-5/+2
Manual parsing is error prone. Suggested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Use existing policy for pipeThomas Gleixner1-2/+1
No need for a new one. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2023-06-20remail: Remove unused functions and debug leftoversThomas Gleixner1-49/+0
Spring cleaning. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-11-05remail: v13v0.13Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-11-05remail: Fix the from manglingThomas Gleixner1-0/+1
The comment in mangle_from() says that if there is not a real name then the email address is mangled by replacing @ with _at_. The comment is great just the implementation is not doing so. Add the replacement functionality. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-11-01remail: v0.12v0.12Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-11-01remail: Allow optional transport based securityThomas Gleixner6-14/+49
Add an "encryption" option 'use_transport' which does not bother with encryption and just relies on transport security. For admins this makes sense as none of the admin messages is really confidential. This is also a valid option for a subscriber and makes some sense in scenarios where the mail provider manages the subscriber key (sic!) and does server side decryption. Think twice before using this. Requested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
2020-09-19remail: v0.11v0.11Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-09-19remail/pipe: Add command line option to handle config updatesThomas Gleixner3-3/+17
When using pipe mode configuration updates are not handled until the next mail is sent to the list. That means that e.g. welcome mails are delayed. Add a command line option to allow the invocation of remail_pipe just to deal with configuration updates without trying to process mail from stdin. The update handling is serialized against concurrent incoming mail via the folder lock, so no extra serialization is required. Whichever comes first handles it. Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
2020-09-04remail: v0.10v0.10Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-09-04remail/smime: Store sender informationThomas Gleixner1-8/+33
For contact points (open list) it's required to collect the sender information, email address and if available the S/MIME certificate which is contained in the signature. Set the encryption method info and if the mail is signed store the S/MIME certificate. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-09-04remail/gpg: Store sender informationThomas Gleixner1-5/+50
For contact points (open list) it's required to collect the sender information, email address and if available the GPG key which is contained in the signature. Set the encryption method info and if the mail is signed store the GPG key. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-09-04remail: Retrieve sender informationThomas Gleixner6-24/+80
For open lists and especially contact points the 'From' mangling is suboptimal as the senders email address is not contained in the mail itself. Due to re-encryption a eventual signature is not longer intact which means that the GPG key or the S/MIME certificate which are embedded into the signature are not transported either. Add infrastructure to collect sender information including key/certificate if available and attach it to the mail. The first attachment contains sender information and the second one if available contains the key or the certificate. The information is only stored when the config switch is enabled and the sender is not subscribed to the list. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-09-04remail/smime: Use certificate embedded in signature for verificationThomas Gleixner1-6/+5
An open list does not have the certificate of senders and for signature verification there is no requirement to have the certificate on disk. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-09-04remail/remaild: Fix failure messageThomas Gleixner1-3/+3
While handling an exception in process_msg() the handler triggers another one by trying to print a undefined variable (mailfile). Hand the mailfile name into the function. Use 'pipe input' for pipe mode. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-11v0.9v0.9Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-11remail/mail: Handle dwmw2s magic evo pluginThomas Gleixner1-0/+53
dwmw2's evolution plugin which seems to workaround ms-exchange oddities has another interesting format not handled by remail yet: multipart/mixed with: - empty text/plain section - application/pgp-encrypted - application/octed-stream Check for this with at least some sanity checks and morph it into a regular multipart/encrypted message so decrypt can handle it without adding more mess to that part. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-11remail/mail: Add missing encrypted.asc filenameThomas Gleixner1-2/+5
Assuming that there is a limited number of possible filenames is just wrong. Add yet another one. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-04remail: v0.8v0.8Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-04remaild: Also notify on IN_MOVED_TO eventsAndreas Rammhold1-1/+6
Some MTAs move mails into the maildir after constructing them in some temporary path. Signed-off-by: Andreas Rammhold <andreas@rammhold.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-04config: Introduce an enabled flag for S/MIMEAndreas Rammhold4-6/+18
This allows setups where there is no S/MIME. In some scenarios using just GPG is fine and S/MIME might even be discouraged. Previously this required to provide a dummy S/MIME key just to make remail happy. With this new flag there is no need for that key if S/MIME is not required for the list. Signed-off-by: Andreas Rammhold <andreas@rammhold.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-04remail: Relax the mail validation so new gTLDs have a chance to passAndreas Rammhold1-1/+1
These days it is common to see mail addresses from the newer TLDs that do not always fit in two to three chracters. These are not covered by the basic mail address validation regex. Relax the requirement from two or three characters to just two or more characters to covers these. Signed-off-by: Andreas Rammhold <andreas@rammhold.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-04config: Pass the incorrect mail address instead of the config pathAndreas Rammhold1-1/+1
Previously remail just logged the path of the attribute (e.g. base.lists.demo.listaccount.addr) instead of the actually mail address that wasn't valid. Signed-off-by: Andreas Rammhold <andreas@rammhold.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-03-04config: Throw correct exception when address isn't validAndreas Rammhold1-1/+1
Signed-off-by: Andreas Rammhold <andreas@rammhold.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-02-20remail/lists: Emit warning text instead of 'txt'Thomas Gleixner1-1/+1
'txt' is pretty useless in syslog and admin reports. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-02-19remail: v0.7v0.7Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-02-19remail/gpg: Use the lists private key for signingThomas Gleixner1-1/+6
Konstantin reported that outgoing mail from a mailing list is signed with the default private key found in the private keyring. That's caused by just handing boolen True into the 'sign' argument of gpg_encrypt() while the documentation clearly says: sign (defaults to None) Either the Boolean value True, or the fingerprint of a key which is used to sign the encrypted data. If True is specified, the default key is used for signing. When not specified, the data is not signed. Hand the list account fingerprint in if signing is enabled in the configuration. Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
2020-02-17remail: v0.6v0.6Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-02-17Documentation: Add mailinglist infoThomas Gleixner2-0/+40
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-02-17ruamel/config: Use ruamel.yaml instead of yamlAndreas Rammhold1-2/+3
This removes the (undocumented) dependency on PyYAML and just uses ruamel.yaml that is already a dependency. Signed-off-by: Andreas Rammhold <andreas@rammhold.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-01-09remail: v0.5v0.5Thomas Gleixner1-1/+1
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-01-09remail: Make sure list configs inherit global gpg/smimeKonstantin Ryabitsev1-4/+7
Per-list config dictionaries were always instantiated with default gpg configuration because global gpg/smime settings were being ignored. This change makes sure that smime and gpg options set on the global level are inherited by list-specific configurations. Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2020-01-09remail: Fix default list-id value to conform to RFC2919Konstantin Ryabitsev2-3/+10
According to RFC2919, List-Id header should be in the form of a hostname value enclosed inside angle brackets. This change does two things: 1. Fixes the default to be the list address with "@" replaced by a "." 2. Allows setting custom list-id values inside remail.yaml 3. Documents the "listid" optional setting in the manpage Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://tools.ietf.org/html/rfc2919
2020-01-09remail: Add requirements.txt fileKonstantin Ryabitsev1-0/+5
Using a requirements.txt file makes it easier to install dependencies via the pip python package manager: pip install -r requirements.txt This is particularly handy for testing when running via virtualenv. Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-14remail/remaild: Use correct path for frozen mails and update log messageThomas Gleixner1-7/+6
Store the frozen mails in maildir.frozen/new and not in the base directory. Move the log message to the actual frozen handling function and provide the correct file pathes in the log. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-13remail/mail: Handle Outlook GPG plugin properThomas Gleixner1-20/+34
The Outlook GPG plugin works in interesting two variants: 1) msg.asc or msc.gpg provided as a plain attachement without PGP envelope 2) GpgOL_MIME_structure.txt contains a fully enveloped PGP payload with the proper headers. Of course everything can be base64 encoded and the number of payload sections is variable as well. Implement the handling for #2 so it can coexist with the existing workaround for #1. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-13remail/mail: Sanitize incoming headersThomas Gleixner1-0/+5
Remove CR/LF leftovers which might be in incoming headers before setting them. Happens when handling the weird GPG Outlook attachments. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-13remail/pipe: Allow UTF-8 for incoming mailsThomas Gleixner1-1/+2
Similar to mails in files, this needs to be explicitly enabled. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-12remail/mail: Add yet another outlook magic filenameThomas Gleixner1-1/+1
GpgOL_MIME_structure.txt is missing from the outlook GPG repair list. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-11remail: version 0.4v0.4Thomas Gleixner1-1/+1
Bump the version number. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-11remail/gpg: Allow specifying path to the gpgbinary to useKonstantin Ryabitsev3-0/+7
We want to be able to support ECC subkeys, which limits us to gnupg versions 2.2 and above. CentOS-7 ships with gnupg-2.0, which cannot be easily upgraded to 2.2 due to a slew of potential problems, so we install the newer version into /opt/gnupg22 and must call it as /opt/gnupg22/bin/gpg. Allow specifying gpg binary path to use instead of the default "gpg" in $PATH. Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-01remail: Add remail_pipe scriptThomas Gleixner6-22/+171
Add a handle pipe function to the remailer and a pipe script for handling mail in a MTA delivery path. Requested-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-11-01Documentation: Rename configuration man pageThomas Gleixner4-3/+3
The upcoming pipe script will use the same configuration. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-09-22remail: Add TODO and a hacky service fileThomas Gleixner2-0/+25
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2019-09-22remail: Initial importThomas Gleixner48-0/+5299
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
generated by cgit 1.2.3-korg (git 2.39.0) at 2024-05-17 10:35:29 +0000