diff options
| author | Dave Hansen <haveblue@us.ibm.com> | 2005-01-03 04:15:51 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-01-03 04:15:51 -0800 |
| commit | 422e43d45514a352c5dd79dc56ca66da321d9075 (patch) | |
| tree | af89fe7263f96edb405ea47cf6ae40e2f6b10d95 /net | |
| parent | ea86630e7e3d4d96a506e29adf8dcb0b44778908 (diff) | |
| download | history-422e43d45514a352c5dd79dc56ca66da321d9075.tar.gz | |
[PATCH] kill off highmem_start_page
People love to do comparisons with highmem_start_page. However, where
CONFIG_HIGHMEM=y and there is no actual highmem, there's no real page at
*highmem_start_page.
That's usually not a problem, but CONFIG_NONLINEAR is a bit more strict and
catches the bogus address tranlations.
There are about a gillion different ways to find out of a 'struct page' is
highmem or not. Why not just check page_flags? Just use PageHighMem()
wherever there used to be a highmem_start_page comparison. Then, kill off
highmem_start_page.
This removes more code than it adds, and gets rid of some nasty
#ifdefs in .c files.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 051353be45c889..6ee78b6595aa92 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1119,7 +1119,7 @@ static inline int illegal_highdma(struct net_device *dev, struct sk_buff *skb) return 0; for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) - if (skb_shinfo(skb)->frags[i].page >= highmem_start_page) + if (PageHighMem(skb_shinfo(skb)->frags[i].page)) return 1; return 0; |