diff options
| author | Andrew Morton <akpm@osdl.org> | 2004-07-10 19:34:41 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2004-07-10 19:34:41 -0700 |
| commit | f4d309cfaf5d5dcd1a57b1ca02b03e6af6004e3b (patch) | |
| tree | ebf8b03757f0b8fdbeb4bc2dc080b928b61bc120 /mm | |
| parent | 087701ef405d90b391b26bd5db9168b4f3c3c0d6 (diff) | |
| download | history-f4d309cfaf5d5dcd1a57b1ca02b03e6af6004e3b.tar.gz | |
[PATCH] slab: fix get_user inside spinlock
This little debugging __get_user is in fact happening inside a spinlock. It
was never very useful, and has caused problems for some architectures in the
past. Let's just remove it.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/slab.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/mm/slab.c b/mm/slab.c index 6087307f778869..34d9e5b5ebfa40 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2833,8 +2833,6 @@ static int s_show(struct seq_file *m, void *p) unsigned long num_slabs; const char *name; char *error = NULL; - mm_segment_t old_fs; - char tmp; check_irq_on(); spin_lock_irq(&cachep->spinlock); @@ -2868,17 +2866,6 @@ static int s_show(struct seq_file *m, void *p) error = "free_objects accounting error"; name = cachep->name; - - /* - * Check to see if `name' resides inside a module which has been - * unloaded (someone forgot to destroy their cache) - */ - old_fs = get_fs(); - set_fs(KERNEL_DS); - if (__get_user(tmp, name)) - name = "broken"; - set_fs(old_fs); - if (error) printk(KERN_ERR "slab: cache %s error: %s\n", name, error); |