diff options
author | Adrian Bunk <bunk@stusta.de> | 2005-01-07 22:33:39 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@evo.osdl.org> | 2005-01-07 22:33:39 -0800 |
commit | 16e05d61269bd00fe16c5300faf81eb516eea9ed (patch) | |
tree | 02aa3aa601ac834c0cd62bd63747ce3fec8c8c91 /lib | |
parent | 2bec6c709f6b3029bd10bc2c41e1797879517c29 (diff) | |
download | history-16e05d61269bd00fe16c5300faf81eb516eea9ed.tar.gz |
[PATCH] remove IN_STRING_C
IN_STRING_C was an i386-specific hack by Andi Kleen to provide out-of-line
versions of some lib/string.c functions that aren't directly used on i386
(because there are inline assembly versions).
This can cause problems if gcc chooses to transparently replace a call to one
string function with a call to another string function (the example Andi gave
was a replacement of a sprintf call with a strcpy call) which generates a
function call to the replacement function.
The problems observed by Andi only occur in recent kernels without
-fno-unit-at-a-time.
With -ffreestanding it can't even cause any problems in case we'd one day drop
the -fno-unit-at-a-time since gcc mustn't assume in a freestanding environment
that all standard C library functions are available.
The effect of this patch is a small space saving in the kernel.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/string.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/string.c b/lib/string.c index c1b1b58747fe0e..4820e317f39b0e 100644 --- a/lib/string.c +++ b/lib/string.c @@ -19,8 +19,6 @@ * - Kissed strtok() goodbye */ -#define IN_STRING_C 1 - #include <linux/types.h> #include <linux/string.h> #include <linux/ctype.h> |