diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2005-01-11 03:18:21 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-01-11 03:18:21 -0800 |
| commit | 0afec568aa9291e792fca96971d204ea6ba32f0d (patch) | |
| tree | 5031e451874e9b2e9c9263d33b5da86bd48b536b /kernel | |
| parent | bf36f91f08100b758a4f12811da05b9c1ce09c90 (diff) | |
| download | history-0afec568aa9291e792fca96971d204ea6ba32f0d.tar.gz | |
[PATCH] Catch module parameter parsing failures
Radheka Godse <radheka.godse@intel.com> pointed out that parameter parsing
failures allow a module still to be loaded. Trivial fix.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/module.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/module.c b/kernel/module.c index f44ebfd656c686..ce427b675b98fa 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1691,6 +1691,9 @@ static struct module *load_module(void __user *umod, / sizeof(struct kernel_param), NULL); } + if (err < 0) + goto arch_cleanup; + err = mod_sysfs_setup(mod, (struct kernel_param *) sechdrs[setupindex].sh_addr, |